Styling option should not override option:checked UA style

Styling option should not override option:checked UA style

This adds !important to option:checked styles, so that styling option won't override the selected appearance.
This adds -internal-listbox which applies to listbox mode select elements.
We need it because we can't remove the !important styles for select[size=0], select[size=1]

BUG=398417
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179782

[tkent, 2014-08-07 08:08:58]

https://codereview.chromium.org/450623002/diff/1/Source/core/css/html.css
File Source/core/css/html.css (right):

https://codereview.chromium.org/450623002/diff/1/Source/core/css/html.css#new...
Source/core/css/html.css:786: background-color:
-internal-active-list-box-selection !important;
Does this mean web authors can't specify option:checked style?

[keishi, 2014-08-07 08:10:23]

On 2014/08/07 08:08:58, tkent wrote:
> https://codereview.chromium.org/450623002/diff/1/Source/core/css/html.css
> File Source/core/css/html.css (right):
> 
>
https://codereview.chromium.org/450623002/diff/1/Source/core/css/html.css#new...
> Source/core/css/html.css:786: background-color:
> -internal-active-list-box-selection !important;
> Does this mean web authors can't specify option:checked style?

I forgot to mention. I checked Firefox and it turned out that you can't style
color and background-color for option:checked. This will behave the same way.

[tkent, 2014-08-07 09:01:37]

On 2014/08/07 08:10:23, keishi wrote:
> On 2014/08/07 08:08:58, tkent wrote:
> > https://codereview.chromium.org/450623002/diff/1/Source/core/css/html.css
> > File Source/core/css/html.css (right):
> > 
> >
>
https://codereview.chromium.org/450623002/diff/1/Source/core/css/html.css#new...
> > Source/core/css/html.css:786: background-color:
> > -internal-active-list-box-selection !important;
> > Does this mean web authors can't specify option:checked style?
> 
> I forgot to mention. I checked Firefox and it turned out that you can't style
> color and background-color for option:checked. This will behave the same way.

We discussed offline, and confirmed that Blink haven't supported option:checked
styling (or very buggy).  So, this CL is ok.
lgtm.  But please investigate the unit test failure.

[keishi, 2014-08-07 10:55:47]

The CQ bit was checked by keishi@chromium.org

[keishi, 2014-08-07 10:56:19]

The CQ bit was unchecked by keishi@chromium.org

[keishi, 2014-08-08 02:12:13]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2014-08-08 02:13:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/keishi@chromium.org/450623002/20001

[commit-bot: I haz the power, 2014-08-08 03:39:49]

Change committed as 179782