Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 450543002: Make ContextualSearchPromoSource Android-only. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 4 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Project:
chromium
Visibility:
Public.

Description

Make ContextualSearchPromoSource Android-only. BUG=333201 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288075

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -162 lines) Patch
D chrome/browser/search/contextual_search_promo_source.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/search/contextual_search_promo_source.cc View 1 chunk +0 lines, -99 lines 0 comments Download
A + chrome/browser/search/contextual_search_promo_source_android.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + chrome/browser/search/contextual_search_promo_source_android.cc View 4 chunks +11 lines, -10 lines 2 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
Will ContextualSearchPromoSource ever be used on non-Android platforms?
6 years, 4 months ago (2014-08-06 23:37:10 UTC) #1
Lei Zhang
https://codereview.chromium.org/450543002/diff/20001/chrome/browser/search/contextual_search_promo_source_android.cc File chrome/browser/search/contextual_search_promo_source_android.cc (right): https://codereview.chromium.org/450543002/diff/20001/chrome/browser/search/contextual_search_promo_source_android.cc#newcode43 chrome/browser/search/contextual_search_promo_source_android.cc:43: SendResource(IDR_CONTEXTUAL_SEARCH_PROMO_CSS, callback); FYI, these should not exist on non-Android ...
6 years, 4 months ago (2014-08-06 23:47:23 UTC) #2
Mathieu
lgtm, sorry for the trouble. https://codereview.chromium.org/450543002/diff/20001/chrome/browser/search/contextual_search_promo_source_android.cc File chrome/browser/search/contextual_search_promo_source_android.cc (right): https://codereview.chromium.org/450543002/diff/20001/chrome/browser/search/contextual_search_promo_source_android.cc#newcode43 chrome/browser/search/contextual_search_promo_source_android.cc:43: SendResource(IDR_CONTEXTUAL_SEARCH_PROMO_CSS, callback); On 2014/08/06 ...
6 years, 4 months ago (2014-08-07 13:41:14 UTC) #3
Mathieu
The CQ bit was checked by mathp@chromium.org
6 years, 4 months ago (2014-08-07 13:41:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/450543002/20001
6 years, 4 months ago (2014-08-07 13:43:18 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 16:30:58 UTC) #6
Message was sent while issue was closed. 
Change committed as 288075

Powered by Google App Engine
This is Rietveld 408576698