Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 450533008: DevTools: fix inspector-protocol css tests (Closed)

Created:
6 years, 4 months ago by lushnikov
Modified:
6 years, 4 months ago
Reviewers:
apavlov, vsevik, dgozman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: fix inspector-protocol css tests Currently, there are helper methods that constantly re-query document node id. This turns out to be harmful as 'getDocument' command is supposed to be invoked only once in the beginning of the session. R=vsevik, apavlov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179817

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -19 lines) Patch
M LayoutTests/inspector-protocol/css/css-create-stylesheet-and-add-rule.html View 4 chunks +11 lines, -4 lines 0 comments Download
M LayoutTests/inspector-protocol/css/css-protocol-test.js View 2 chunks +4 lines, -9 lines 0 comments Download
M LayoutTests/inspector-protocol/css/css-set-property-text-inline.html View 1 chunk +9 lines, -2 lines 0 comments Download
M LayoutTests/inspector-protocol/css/css-shadow-host-content-selector.html View 1 chunk +9 lines, -2 lines 0 comments Download
M LayoutTests/inspector-protocol/css/css-shadow-host-rule.html View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
lushnikov
ptal
6 years, 4 months ago (2014-08-07 17:06:39 UTC) #1
apavlov
lgtm
6 years, 4 months ago (2014-08-07 19:52:51 UTC) #2
dgozman
> Currently, there are helper methods that constantly re-query document > node id. This turns ...
6 years, 4 months ago (2014-08-08 05:24:49 UTC) #3
vsevik
On 2014/08/08 05:24:49, dgozman wrote: > > Currently, there are helper methods that constantly re-query ...
6 years, 4 months ago (2014-08-08 08:53:15 UTC) #4
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 4 months ago (2014-08-08 08:53:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/450533008/1
6 years, 4 months ago (2014-08-08 08:54:01 UTC) #6
dgozman
> This is definitely out of scope of this bug and I don't think we ...
6 years, 4 months ago (2014-08-08 08:55:43 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 10:58:31 UTC) #8
Message was sent while issue was closed.
Change committed as 179817

Powered by Google App Engine
This is Rietveld 408576698