Issue 450533007: Remove children of <shadow> element added by JS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 450533007: Remove children of <shadow> element added by JS (Closed)

Created:
6 years, 4 months ago by deepak.sa

Modified:
6 years, 4 months ago

Reviewers:
esprehn, hayato

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove children of <shadow> element added by JS Update the Layout tests for shadow so that they dont use child elements of <shadow>. In this patch, childs which are added through JS is being removed. BUG=334957 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179908

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -22 lines)			Patch
M	LayoutTests/fast/dom/shadow/composed-shadow-tree-walker.html	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/composed-shadow-tree-walker-shadow-reprojection.html	View	4 chunks	+5 lines, -10 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/content-pseudo-element-with-deep-combinator-and-host-pseudo-class.html	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/focus-navigation.html	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/focus-navigation-with-multiple-shadow-roots.html	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/hostcontext-pseudo-class.html	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/450533007/1

6 years, 4 months ago (2014-08-11 05:12:03 UTC) #4

Message was sent while issue was closed.

Change committed as 179908

Expand Messages | Collapse Messages