Issue 450533006: Implement scale*() methods in DOMMatrix.

Issue 450533006: Implement scale*() methods in DOMMatrix. (Closed)

Created:
6 years, 4 months ago by zino

Modified:
6 years, 4 months ago

Reviewers:
krit, Rik, eseidel

CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Implement scale*() methods in DOMMatrix. The methods multiply a scale transformation on the current matrix. The specification: http://dev.w3.org/fxtf/geometry/ Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V_bJNtOg0oM BUG=388780 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180421

Patch Set 2 : use TransformationMatrix #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+260 lines, -0 lines)			Patch
M	LayoutTests/TestExpectations	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html	View	1	1 chunk	+174 lines, -0 lines	0 comments	Download
M	Source/core/dom/DOMMatrix.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/core/dom/DOMMatrix.cpp	View	1	1 chunk	+35 lines, -0 lines	0 comments	Download
M	Source/core/dom/DOMMatrix.idl	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	Source/core/dom/DOMMatrixReadOnly.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/core/dom/DOMMatrixReadOnly.cpp	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	Source/core/dom/DOMMatrixReadOnly.idl	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

krit

Great patch! Just some snippets. https://codereview.chromium.org/450533006/diff/20001/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html File LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html (right): https://codereview.chromium.org/450533006/diff/20001/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html#newcode5 LayoutTests/fast/dom/geometry-interfaces-dom-matrix-scale.html:5: <script src="../../resources/js-test.js"></script> Could you ...

6 years, 4 months ago (2014-08-08 05:47:34 UTC) #3

zino

Dear Dirk, I addressed all your comments. Could you take a look again? Thank you. ...

6 years, 4 months ago (2014-08-17 11:35:25 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/450533006/100001

6 years, 4 months ago (2014-08-17 22:26:18 UTC) #7

commit-bot: I haz the power

6 years, 4 months ago (2014-08-17 23:26:57 UTC) #8

Message was sent while issue was closed.

Committed patchset #2 (100001) as 180421

Expand Messages | Collapse Messages