Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: media/base/video_frame.h

Issue 45053003: Add UMA metrics for ffmpeg color ranges. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Drop the 'FORMAT_'. Just 'HISTOGRAM_MAX', it's cleaner. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/video_frame.h
diff --git a/media/base/video_frame.h b/media/base/video_frame.h
index df383d0d79849a9b746645cdf07febedeceaf461..8deab2db7ce1ed120b8991c59ea8fc33f9967660 100644
--- a/media/base/video_frame.h
+++ b/media/base/video_frame.h
@@ -39,6 +39,7 @@ class MEDIA_EXPORT VideoFrame : public base::RefCountedThreadSafe<VideoFrame> {
// Surface formats roughly based on FOURCC labels, see:
// http://www.fourcc.org/rgb.php
// http://www.fourcc.org/yuv.php
+ // Logged to UMA, so never reuse values.
enum Format {
INVALID = 0, // Invalid format value. Used for error reporting.
RGB32 = 4, // 32bpp RGB packed with extra byte 8:8:8
@@ -51,6 +52,7 @@ class MEDIA_EXPORT VideoFrame : public base::RefCountedThreadSafe<VideoFrame> {
HOLE = 13, // Hole frame.
#endif
YV12A = 14, // 20bpp YUVA planar 1x1 Y, 2x2 VU, 1x1 A samples.
+ HISTOGRAM_MAX, // Must be greater than all other formats.
};
// Returns the name of a Format as a string.

Powered by Google App Engine
This is Rietveld 408576698