Add UMA metrics for ffmpeg color ranges.

media/ffmpeg/ffmpeg_common.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/ffmpeg/ffmpeg_common.h"
 
 #include "base/basictypes.h"
 #include "base/logging.h"
+#include "base/metrics/histogram.h"
 #include "media/base/decoder_buffer.h"
 #include "media/base/video_frame.h"
 #include "media/base/video_util.h"
 
 namespace media {
 
 // Why FF_INPUT_BUFFER_PADDING_SIZE? FFmpeg assumes all input buffers are
 // padded. Check here to ensure FFmpeg only receives data padded to its
 // specifications.
 COMPILE_ASSERT(DecoderBuffer::kPaddingSize >= FF_INPUT_BUFFER_PADDING_SIZE,
@@ skipping 343 matching lines @@
   if (codec == kCodecVP8)
     profile = VP8PROFILE_MAIN;
   else if (codec == kCodecVP9)
     profile = VP9PROFILE_MAIN;
   else
     profile = ProfileIDToVideoCodecProfile(stream->codec->profile);
 
   gfx::Size natural_size = GetNaturalSize(
       visible_rect.size(), aspect_ratio.num, aspect_ratio.den);
 
+  if (record_stats) {
+    UMA_HISTOGRAM_ENUMERATION(
+        "Media.VideoPixelFormat", stream->codec->pix_fmt, PIX_FMT_NB + 1);

[scherkus (not reviewing), 2013/10/28 21:16:39]

you're correct that since these values aren't guaranteed to be stable, we
shouldn't use them for UMA

let's use VideoFrame::Format and add a comment to that enum that values
shouldn't change, similar to other enums:
https://code.google.com/p/chromium/codesearch#chromium/src/media/base/pipelin...

+    UMA_HISTOGRAM_ENUMERATION("Media.VideoColorRange",
+                              stream->codec->color_range,
+                              AVCOL_RANGE_NB + 1);
+  }
+
   VideoFrame::Format format = PixelFormatToVideoFormat(stream->codec->pix_fmt);
   if (codec == kCodecVP9) {
     // TODO(tomfinegan): libavcodec doesn't know about VP9.
     format = VideoFrame::YV12;
     coded_size = natural_size;
   }
 
   bool is_encrypted = false;
   AVDictionaryEntry* key = av_dict_get(stream->metadata, "enc_key_id", NULL, 0);
   if (key)
@@ skipping 129 matching lines @@
       return PIX_FMT_YUV420P;
     case VideoFrame::YV12A:
       return PIX_FMT_YUVA420P;
     default:
       DVLOG(1) << "Unsupported VideoFrame::Format: " << video_format;
   }
   return PIX_FMT_NONE;
 }
 
 }  // namespace media