Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 45053002: Remove SpeechSynthesisVoice's virtual destructor (Closed)

Created:
7 years, 1 month ago by Inactive
Modified:
7 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove SpeechSynthesisVoice's virtual destructor Remove SpeechSynthesisVoice's destructor as it was empty and marked as virtual. This avoids creating an unnecessary vtable as this class is never subclassed, nor does it have any virtual function. BUG=311561 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160620

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/modules/speech/SpeechSynthesisVoice.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
7 years, 1 month ago (2013-10-25 18:32:36 UTC) #1
eseidel
lgtm Are you using a tool to scan the vtables looking for (nearly) empty ones?
7 years, 1 month ago (2013-10-25 18:43:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/45053002/1
7 years, 1 month ago (2013-10-25 18:43:53 UTC) #3
Inactive
On 2013/10/25 18:43:39, eseidel wrote: > lgtm > > Are you using a tool to ...
7 years, 1 month ago (2013-10-25 18:46:35 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-10-25 20:17:49 UTC) #5
Message was sent while issue was closed.
Change committed as 160620

Powered by Google App Engine
This is Rietveld 408576698