Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 450483004: Set the grit .d file dir in GN build properly. (Closed)

Created:
6 years, 4 months ago by brettw
Modified:
6 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Set the grit .d file dir in GN build properly. Put the .d file in the same directory as the output from grit. Currently it uses the default location for the .d file all the time, even in cases where the output directory is overridden and the rest of the files go somewhere else. R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287877

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/secondary/tools/grit/grit_rule.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
6 years, 4 months ago (2014-08-06 21:01:33 UTC) #1
scottmg
lgtm, does this fix Nico's thing or unrelated?
6 years, 4 months ago (2014-08-06 21:07:53 UTC) #2
brettw
On 2014/08/06 21:07:53, scottmg wrote: > lgtm, does this fix Nico's thing or unrelated? This ...
6 years, 4 months ago (2014-08-06 21:12:36 UTC) #3
brettw
6 years, 4 months ago (2014-08-06 22:35:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 287877 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698