Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 450433002: [Resources] Move roboto.woff and add roboto.woff2 to a roboto/ directory (Closed)

Created:
6 years, 4 months ago by Mathieu
Modified:
6 years, 4 months ago
Reviewers:
jam, huangs, Dan Beam
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Project:
chromium
Visibility:
Public.

Description

[Resources] Move roboto.woff and add roboto.woff2 to a roboto/ directory Previously under resources/contextual_search/, now moving Roboto to its own directory. Also using Roboto2 now. BUG=401100 R=dbeam@chromium.org, huangs@chromium.org TBR=jam TEST=Didn't break Contextual Search promo Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288386

Patch Set 1 #

Patch Set 2 : fallback to sans-serif #

Total comments: 2

Patch Set 3 : removed local ntp sources #

Patch Set 4 : resource android only #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M chrome/browser/browser_resources.grd View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/contextual_search/promo.css View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
D chrome/browser/resources/contextual_search/roboto.woff View Binary file 0 comments Download
A + chrome/browser/resources/roboto/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/roboto/roboto.woff View Binary file 0 comments Download
A chrome/browser/resources/roboto/roboto.woff2 View Binary file 0 comments Download
M chrome/browser/search/contextual_search_promo_source_android.cc View 1 2 3 4 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Mathieu
Hello, Can you have a look? dbeam: new directory in resources sam: rest Thanks!
6 years, 4 months ago (2014-08-06 16:23:42 UTC) #1
huangs
lgtm
6 years, 4 months ago (2014-08-06 17:42:26 UTC) #2
Dan Beam
lgtm https://codereview.chromium.org/450433002/diff/20001/chrome/browser/resources/contextual_search/promo.css File chrome/browser/resources/contextual_search/promo.css (right): https://codereview.chromium.org/450433002/diff/20001/chrome/browser/resources/contextual_search/promo.css#newcode8 chrome/browser/resources/contextual_search/promo.css:8: src: local('Roboto'), local('Roboto2-Regular'), url(/roboto.woff2) format('woff2'), url(/roboto.woff) format('woff'); 80 ...
6 years, 4 months ago (2014-08-06 21:01:12 UTC) #3
Mathieu
The CQ bit was checked by mathp@chromium.org
6 years, 4 months ago (2014-08-08 14:08:00 UTC) #4
Mathieu
Submitting https://codereview.chromium.org/450433002/diff/20001/chrome/browser/resources/contextual_search/promo.css File chrome/browser/resources/contextual_search/promo.css (right): https://codereview.chromium.org/450433002/diff/20001/chrome/browser/resources/contextual_search/promo.css#newcode8 chrome/browser/resources/contextual_search/promo.css:8: src: local('Roboto'), local('Roboto2-Regular'), url(/roboto.woff2) format('woff2'), url(/roboto.woff) format('woff'); On ...
6 years, 4 months ago (2014-08-08 14:08:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mathp@chromium.org/450433002/80001
6 years, 4 months ago (2014-08-08 14:08:51 UTC) #6
Mathieu
The CQ bit was unchecked by mathp@chromium.org
6 years, 4 months ago (2014-08-08 17:07:06 UTC) #7
Mathieu
TBR jam since dbeam@ looked at the resources added.
6 years, 4 months ago (2014-08-08 17:09:28 UTC) #8
Mathieu
The CQ bit was checked by mathp@chromium.org
6 years, 4 months ago (2014-08-08 17:09:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mathp@chromium.org/450433002/80001
6 years, 4 months ago (2014-08-08 17:11:36 UTC) #10
Mathieu
6 years, 4 months ago (2014-08-08 17:27:34 UTC) #11
Message was sent while issue was closed. 
Committed patchset #5 manually as 288386 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698