Issue 45042: Fix for native button focus bug

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 45042: Fix for native button focus bug (Closed)

Created:
11 years, 9 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Focusing a native button through a RequestFocus call would not result in the actual button showing as focused. This is because the NativeButton is the one getting focused not the NativeControl wrapper. This CL adds forwarding the focus to the NativeControl so the HWND really gets focused. It also associates the NativeButton view with the NativeControl, so that when the HWND is focused (through a click for example), the focus manager has the NativeButton as the focused view (not the NativeControl wrapper). BUG=9253 TEST=Open the option panel. Press tab several times. The focus should move as expected to the different buttons and views in the page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12420

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -3 lines)			Patch
M	chrome/views/controls/button/native_button.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/views/controls/button/native_button.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/views/controls/button/native_button_win.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/views/controls/button/native_button_win.cc	View	1 2	4 chunks	+14 lines, -1 line	0 comments	Download
M	chrome/views/controls/button/native_button_wrapper.h	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM. Thanks for fixing this!

Expand Messages | Collapse Messages

Issue 45042: Fix for native button focus bug (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages