Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 450393002: Renames --analyzer2 to --analyzer (Closed)

Created:
6 years, 4 months ago by sky
Modified:
6 years, 4 months ago
Reviewers:
iannucci
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Project:
tools
Visibility:
Public.

Description

Renames --analyzer2 to --analyzer Finally! TBR as this is a trivial change. BUG=109173 TEST=none R=iannucci@chromium.org TBR=iannucci@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=288410

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M scripts/slave/recipe_modules/filter/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/filter/example.expected/analyzes_error.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/filter/example.expected/analyzes_matches_exes.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/filter/example.expected/analyzes_returns_true.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/filter/example.expected/bad_retcode_doesnt_fail.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/filter/example.expected/basic.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/filter/example.expected/doesnt_match_exclusion.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/no_compile_because_of_analyze.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
6 years, 4 months ago (2014-08-08 17:00:42 UTC) #1
sky
The CQ bit was checked by sky@chromium.org
6 years, 4 months ago (2014-08-08 19:05:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/450393002/1
6 years, 4 months ago (2014-08-08 19:06:40 UTC) #3
commit-bot: I haz the power
Change committed as 288410
6 years, 4 months ago (2014-08-08 19:07:46 UTC) #4
iannucci
6 years, 4 months ago (2014-08-09 02:25:25 UTC) #5
Message was sent while issue was closed. 
On 2014/08/08 19:07:46, I haz the power (commit-bot) wrote:
> Change committed as 288410

retrolgtm

Powered by Google App Engine
This is Rietveld 408576698