Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: remoting/webapp/manifest.json.jinja2

Issue 450383003: Hangout remote desktop part II - background.html and AppLauncher (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address CR Feedbacks Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/manifest.json.jinja2
diff --git a/remoting/webapp/manifest.json.jinja2 b/remoting/webapp/manifest.json.jinja2
index 1ce73d2bb202b0e60c35cee10b5fa1511e516256..c4a72e6c059cf286adfd721d61737e977bee7ccf 100644
--- a/remoting/webapp/manifest.json.jinja2
+++ b/remoting/webapp/manifest.json.jinja2
@@ -13,10 +13,16 @@
}
{% else %}
"background": {
- "scripts": ["background.js"]
- }
+ "page": "background.html"
+ }
{% endif %}
},
+{% if webapp_type == 'v1' %}
+ "background": {
+ "page": "background.html",
+ "persistent": false
+ },
+{% endif %}
Jamie 2014/08/12 20:42:54 Is this needed for this part of the CL? I don't th
kelvinp 2014/08/12 21:42:42 Done.
"icons": {
"128": "chromoting128.webp",
"48": "chromoting48.webp",
@@ -55,6 +61,12 @@
},
{% endif %}
+ "externally_connectable": {
+ "matches": [
+ "https://*.talkgadget.google.com/*"
+ ]
+ },
Jamie 2014/08/12 20:42:55 As above, I think this probably belongs in one of
kelvinp 2014/08/12 21:42:42 Done.
+
"permissions": [
"{{ OAUTH2_ACCOUNTS_HOST }}/*",
"{{ OAUTH2_API_BASE_URL }}/*",

Powered by Google App Engine
This is Rietveld 408576698