Simplify LoginState methods.

Simplify LoginState methods.

No functional change, only making the behavior of the functions more obvious.

Retail mode is obsolete in R38 and later according to crbug.com/372703 and not supported anymore after this change.

BUG=NONE
(for chrome/browser/metrics/perf_provider_chromeos.cc, API usage)
TBR=isherman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288476

[pneubeck (no reviews), 2014-08-08 16:40:16]

ptal. this doesn't change the TPM loading.

[pneubeck (no reviews), 2014-08-08 16:41:26]

@Mark: Please review changes in 
 chrome/browser/metrics/perf_provider_chromeos.cc

[Mark P, 2014-08-08 16:43:17]

On 2014/08/08 16:41:26, pneubeck wrote:
> @Mark: Please review changes in 
>  chrome/browser/metrics/perf_provider_chromeos.cc

I don't know why you're asking me to review this change.  I'm not qualified.

--mark

[stevenjb, 2014-08-08 16:57:06]

We should confirm that LOGGED_IN_USER_RETAIL_MODE is deprecated and eliminate
it, replacing the translation in UserManagerBase::UpdateLoginState with a
CHECK(). Otherwise I believe we need to treat it like PUBLIC_SESSION.

https://codereview.chromium.org/450363002/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/options/wifi_config_view.cc (right):

https://codereview.chromium.org/450363002/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/options/wifi_config_view.cc:578:
LoginState::Get()->IsGuestSessionUser()) {
Do installed certificates in public sessions persist? I guess if it is a public
session then 'login' isn't an option anyway? Maybe we should add a comment to
that effect.

[stevenjb, 2014-08-08 17:01:41]

+isherman@ for c/b/metrics owner

[pneubeck (no reviews), 2014-08-08 18:24:52]

On 2014/08/08 16:57:06, stevenjb wrote:
> We should confirm that LOGGED_IN_USER_RETAIL_MODE is deprecated and eliminate
> it, replacing the translation in UserManagerBase::UpdateLoginState with a
> CHECK(). Otherwise I believe we need to treat it like PUBLIC_SESSION.

I added a check to LoginState, otherwise I'll have to wait till next week for a
review from developers in Russia.
I'm currently trying to get a confirmation that Retail mode is dead.

> 
>
https://codereview.chromium.org/450363002/diff/40001/chrome/browser/chromeos/...
> File chrome/browser/chromeos/options/wifi_config_view.cc (right):
> 
>
https://codereview.chromium.org/450363002/diff/40001/chrome/browser/chromeos/...
> chrome/browser/chromeos/options/wifi_config_view.cc:578:
> LoginState::Get()->IsGuestSessionUser()) {
> Do installed certificates in public sessions persist? I guess if it is a
public
> session then 'login' isn't an option anyway? Maybe we should add a comment to
> that effect.

[stevenjb, 2014-08-08 18:54:44]

lgtm

Could you replace "doesn't have to be maintained in this change" with "is no
longer supported with this change" or somesuch for retail mode?

[pneubeck (no reviews), 2014-08-08 20:45:24]

Just got green light from Vidya to remove retail mode.

https://codereview.chromium.org/450363002/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/options/wifi_config_view.cc (right):

https://codereview.chromium.org/450363002/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/options/wifi_config_view.cc:578:
LoginState::Get()->IsGuestSessionUser()) {
On 2014/08/08 16:57:06, stevenjb wrote:
> Do installed certificates in public sessions persist? I guess if it is a
public
> session then 'login' isn't an option anyway? Maybe we should add a comment to
> that effect.

Yes, right. I don't want to change behavior in this CL so I added the public
session to this condition.

In the follow up, I will remove public session from this condition as the TPM is
loaded and policy can install certs. I think it would be irritating to tell the
user to login in. The other message seems to be more helpful.

[pneubeck (no reviews), 2014-08-08 20:54:19]

The CQ bit was checked by pneubeck@chromium.org

[commit-bot: I haz the power, 2014-08-08 20:56:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pneubeck@chromium.org/450363002/80002

[commit-bot: I haz the power, 2014-08-09 00:23:39]

Change committed as 288476

[stevenjb, 2014-08-12 02:23:18]

https://codereview.chromium.org/450363002/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/options/wifi_config_view.cc (right):

https://codereview.chromium.org/450363002/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/options/wifi_config_view.cc:578:
LoginState::Get()->IsGuestSessionUser()) {
On 2014/08/08 20:45:24, pneubeck wrote:
> On 2014/08/08 16:57:06, stevenjb wrote:
> > Do installed certificates in public sessions persist? I guess if it is a
> public
> > session then 'login' isn't an option anyway? Maybe we should add a comment
to
> > that effect.
> 
> Yes, right. I don't want to change behavior in this CL so I added the public
> session to this condition.
> 
> In the follow up, I will remove public session from this condition as the TPM
is
> loaded and policy can install certs. I think it would be irritating to tell
the
> user to login in. The other message seems to be more helpful.

sgtm