Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 450313002: [Resources] Update the Google logo assets to the proper representations (Closed)

Created:
6 years, 4 months ago by Mathieu
Modified:
6 years, 4 months ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[Resources] Update the Google logo assets to the proper representations This will only affect the Local NTP (offline). Also, in Local NTP use the @2x version and let Chrome downscale it (recommended way, done on the online NTP). BUG=363519 R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288409

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M chrome/app/theme/default_100_percent/common/ntp_google_logo.png View 1 Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/ntp_google_logo.png View 1 Binary file 0 comments Download
M chrome/browser/resources/local_ntp/local_ntp.css View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mathieu
Hello, Can you have a look? Thanks!
6 years, 4 months ago (2014-08-08 18:27:17 UTC) #1
oshima
lgtm
6 years, 4 months ago (2014-08-08 19:01:34 UTC) #2
Mathieu
6 years, 4 months ago (2014-08-08 19:07:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 288409 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698