src/api.cc - Issue 450303003: Tag all prototypes as proto, except those set using __proto__

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 450303003: Tag all prototypes as proto, except those set using __proto__ (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Remove is_shared from Map Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 7098859de3cfa9fa85d786b29cf8eef56846f086..d308c608aa1eb309eed4ab978c98b454d3eb1d29 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -3204,8 +3204,8 @@ bool v8::Object::SetPrototype(Handle<Value> value) {

// to propagate outside.

TryCatch try_catch;

EXCEPTION_PREAMBLE(isolate);

- i::MaybeHandle<i::Object> result = i::JSObject::SetPrototype(

- self, value_obj);

+ i::MaybeHandle<i::Object> result =

+ i::JSObject::SetPrototype(self, value_obj, false);

has_pending_exception = result.is_null();

EXCEPTION_BAILOUT_CHECK(isolate, false);

return true;

« no previous file with comments | « no previous file | src/apinatives.js » ('j') | no next file with comments »