Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 450303003: Tag all prototypes as proto, except those set using __proto__ (Closed)

Created:
6 years, 4 months ago by Toon Verwaest
Modified:
6 years, 4 months ago
Reviewers:
Igor Sheludko, Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Tag all prototypes as proto, except those set using __proto__ BUG= R=ishell@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23042

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : Remove is_shared from Map #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -129 lines) Patch
M src/api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/apinatives.js View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 8 chunks +20 lines, -12 lines 0 comments Download
M src/factory.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/generator.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/math.js View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 2 9 chunks +24 lines, -30 lines 0 comments Download
M src/objects.cc View 1 2 16 chunks +58 lines, -57 lines 0 comments Download
M src/objects-debug.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/objects-inl.h View 1 2 3 chunks +4 lines, -12 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M src/serialize.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/stub-cache.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/v8natives.js View 2 chunks +3 lines, -2 lines 0 comments Download
A + test/mjsunit/runtime-gen/internalsetprototype.js View 1 chunk +1 line, -1 line 0 comments Download
M tools/generate-runtime-tests.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Toon Verwaest
PTAL
6 years, 4 months ago (2014-08-08 14:06:07 UTC) #1
Igor Sheludko
lgtm with a nit: https://codereview.chromium.org/450303003/diff/20001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/450303003/diff/20001/src/objects.cc#newcode12188 src/objects.cc:12188: } The "make-prototype-super-fast" piece of ...
6 years, 4 months ago (2014-08-11 07:42:14 UTC) #2
Toon Verwaest
Addressed comments, which required some intrusive changes. PTAL again.
6 years, 4 months ago (2014-08-11 12:13:32 UTC) #3
Toon Verwaest
Yang, PTAL at patch-set 1 and 2 that address Igors comments.
6 years, 4 months ago (2014-08-11 13:50:29 UTC) #4
Yang
lgtm.
6 years, 4 months ago (2014-08-11 13:56:12 UTC) #5
Toon Verwaest
6 years, 4 months ago (2014-08-11 14:01:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as 23042 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698