Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: src/gpu/gl/GrGLPathRange.cpp

Issue 450283002: Simplify GrGLPathRendering interface (Closed) Base URL: https://skia.googlesource.com/skia.git@02-path-state-to-pathrendering-class
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/gpu/gl/GrGLPath.cpp ('k') | src/gpu/gl/GrGLPathRendering.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 /* 2 /*
3 * Copyright 2014 Google Inc. 3 * Copyright 2014 Google Inc.
4 * 4 *
5 * Use of this source code is governed by a BSD-style license that can be 5 * Use of this source code is governed by a BSD-style license that can be
6 * found in the LICENSE file. 6 * found in the LICENSE file.
7 */ 7 */
8 8
9 #include "GrGLPathRange.h" 9 #include "GrGLPathRange.h"
10 #include "GrGLPath.h" 10 #include "GrGLPath.h"
(...skipping 10 matching lines...) Expand all
21 this->release(); 21 this->release();
22 } 22 }
23 23
24 void GrGLPathRange::initAt(size_t index, const SkPath& skPath) { 24 void GrGLPathRange::initAt(size_t index, const SkPath& skPath) {
25 GrGpuGL* gpu = static_cast<GrGpuGL*>(this->getGpu()); 25 GrGpuGL* gpu = static_cast<GrGpuGL*>(this->getGpu());
26 if (NULL == gpu) { 26 if (NULL == gpu) {
27 return; 27 return;
28 } 28 }
29 29
30 // Make sure the path at this index hasn't been initted already. 30 // Make sure the path at this index hasn't been initted already.
31 SkASSERT(GR_GL_FALSE == gpu->glPathRendering()->isPath(fBasePathID + index)) ; 31 SkDEBUGCODE(
32 GrGLboolean isPath;
33 GR_GL_CALL_RET(gpu->glInterface(), isPath, IsPath(fBasePathID + index))) ;
34 SkASSERT(GR_GL_FALSE == isPath);
32 35
33 GrGLPath::InitPathObject(gpu, fBasePathID + index, skPath, fStroke); 36 GrGLPath::InitPathObject(gpu, fBasePathID + index, skPath, fStroke);
34 ++fNumDefinedPaths; 37 ++fNumDefinedPaths;
35 this->didChangeGpuMemorySize(); 38 this->didChangeGpuMemorySize();
36 } 39 }
37 40
38 void GrGLPathRange::onRelease() { 41 void GrGLPathRange::onRelease() {
39 SkASSERT(NULL != this->getGpu()); 42 SkASSERT(NULL != this->getGpu());
40 43
41 if (0 != fBasePathID && !this->isWrapped()) { 44 if (0 != fBasePathID && !this->isWrapped()) {
42 static_cast<GrGpuGL*>(this->getGpu())->glPathRendering()->deletePaths(fB asePathID, fSize); 45 static_cast<GrGpuGL*>(this->getGpu())->glPathRendering()->deletePaths(fB asePathID, fSize);
43 fBasePathID = 0; 46 fBasePathID = 0;
44 } 47 }
45 48
46 INHERITED::onRelease(); 49 INHERITED::onRelease();
47 } 50 }
48 51
49 void GrGLPathRange::onAbandon() { 52 void GrGLPathRange::onAbandon() {
50 fBasePathID = 0; 53 fBasePathID = 0;
51 54
52 INHERITED::onAbandon(); 55 INHERITED::onAbandon();
53 } 56 }
OLDNEW
« no previous file with comments | « src/gpu/gl/GrGLPath.cpp ('k') | src/gpu/gl/GrGLPathRendering.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698