Generate header file of Linux version information (currently gyp-only).

Generate header file of Linux version information (currently gyp-only).

This isn't yet #included in file_version_info_linux.cc since we haven't
officially cutover to the gyp build.

BUG=8132

[tony, 2009-03-23 23:20:14]

http://codereview.chromium.org/45028/diff/1005/6
File base/base.gyp (right):

http://codereview.chromium.org/45028/diff/1005/6#newcode323
Line 323: 'actions': [
I think we still use base.scons unless people are building with _GYP, right? 
Does there need to be a change to base.scons for now?

http://codereview.chromium.org/45028/diff/1005/9
File chrome/tools/build/linux/version.sh (right):

http://codereview.chromium.org/45028/diff/1005/9#newcode28
Line 28: LASTCHANGE=$(svn info | grep "Revision:" | cut -d" " -f2-)
What happens if the user has git (svn info returns "svn: '.' is not a working
copy"?  It would be nice if this didn't stop the build, although it's ok if the
revision is wrong in that case.  It would be awesome if it still did the right
thing.

[tony, 2009-03-23 23:22:42]

Oh, nevermind, I didn't read the change description.  This is intentionally gyp
only.  Ok, LGTM!

cc'ing adam since it may break his build.

On 2009/03/23 23:20:14, tony wrote:
> http://codereview.chromium.org/45028/diff/1005/6
> File base/base.gyp (right):
> 
> http://codereview.chromium.org/45028/diff/1005/6#newcode323
> Line 323: 'actions': [
> I think we still use base.scons unless people are building with _GYP, right? 
> Does there need to be a change to base.scons for now?
> 
> http://codereview.chromium.org/45028/diff/1005/9
> File chrome/tools/build/linux/version.sh (right):
> 
> http://codereview.chromium.org/45028/diff/1005/9#newcode28
> Line 28: LASTCHANGE=$(svn info | grep "Revision:" | cut -d" " -f2-)
> What happens if the user has git (svn info returns "svn: '.' is not a working
> copy"?  It would be nice if this didn't stop the build, although it's ok if
the
> revision is wrong in that case.  It would be awesome if it still did the right
> thing.

[Michael Moss, 2009-03-23 23:54:54]

> cc'ing adam since it may break his build.

Ugh, I think I see what you meant now, since I had the .cc file in there. I
thought I had taken that out before I sent the review (it should have only been
part of Issue 42542).

> > http://codereview.chromium.org/45028/diff/1005/9#newcode28
> > Line 28: LASTCHANGE=$(svn info | grep "Revision:" | cut -d" " -f2-)
> > What happens if the user has git (svn info returns "svn: '.' is not a
working
> > copy"?  It would be nice if this didn't stop the build, although it's ok if
> the
> > revision is wrong in that case.  It would be awesome if it still did the
right
> > thing.

Yeah, I figured it was fine for it to just be blank in the git case, since I was
mainly concerned with the buildbot builds, which are svn, but I decided to add a
git-svn fallback since that's what I use too.

[sgk, 2009-03-24 00:01:49]

http://codereview.chromium.org/45028/diff/2006/3004
File chrome/tools/build/linux/version.sh (right):

http://codereview.chromium.org/45028/diff/2006/3004#newcode9
Line 9: # shell so we can share the code?
How about translating not into sh but into Python?  The general portability is
significantly better, and that's what we're doing with a lot of the other
scripts.

[Mark Mentovai, 2009-03-24 00:11:29]

http://codereview.chromium.org/45028/diff/2006/3004
File chrome/tools/build/linux/version.sh (right):

http://codereview.chromium.org/45028/diff/2006/3004#newcode1
Line 1: #!/bin/sh
Be sure to set svn:executable on this.  You've invoked it in the .gyp file
without calling 'sh' first, so this must be executable.

[Mark Mentovai, 2009-03-24 00:14:27]

http://codereview.chromium.org/45028/diff/2006/3002
File base/base.gyp (right):

http://codereview.chromium.org/45028/diff/2006/3002#newcode333
Line 333: # TODO(mmoss) What about google-chrome/BRANDING? Build fails
You should write, within this action:

'conditions': [
  ['branding=="Chrome"', {
    'inputs': ['../chrome/app/theme/google-chrome/BRANDING']
  }, {  # else: branding!="Chrome"
    'inputs': ['../chrome/app/theme/chrome/BRANDING']
  }],
],

and remove BRANDING from the "normal" inputs list.  The correct BRANDING file
will be added to inputs depending on the state of the "branding" GYP variable.

[Michael Moss, 2009-03-24 17:20:08]

http://codereview.chromium.org/45028/diff/2006/3002
File base/base.gyp (right):

http://codereview.chromium.org/45028/diff/2006/3002#newcode333
Line 333: # TODO(mmoss) What about google-chrome/BRANDING? Build fails
Done. Thanks for the tip.