Issue 450273003: Uninline HTMLCollection / LiveNodeList's item() and length() member functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 450273003: Uninline HTMLCollection / LiveNodeList's item() and length() member functions (Closed)

Created:
6 years, 4 months ago by Inactive

Modified:
6 years, 4 months ago

Reviewers:
adamk

CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Uninline HTMLCollection / LiveNodeList's item() and length() member functions Uninline HTMLCollection / LiveNodeList's item() and length() member functions as these are big. Those call directly methods on CollectionIndexCache and all of them are inlined. This reduces the stripped release binary size by ~24Kb. I measured the impact of this change on BrowserMark 2.1's DOM Search subtest (which tests this code extensively) and it did not seem to regress: - Before: 5785.4 +/- 0.8% - After: 5835.4 +/- 1% R=adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179852

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -4 lines)			Patch
M	Source/core/dom/LiveNodeList.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/LiveNodeList.cpp	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLCollection.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLCollection.cpp	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/450273003/1

6 years, 4 months ago (2014-08-08 17:36:06 UTC) #4

Message was sent while issue was closed.

Change committed as 179852

Expand Messages | Collapse Messages