Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 450273002: Extend ToBooleanStub to be able to return oddballs. (Closed)

Created:
6 years, 4 months ago by Michael Starzinger
Modified:
6 years, 4 months ago
Reviewers:
titzer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Extend ToBooleanStub to be able to return oddballs. R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22997

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -33 lines) Patch
M src/code-stubs.h View 4 chunks +22 lines, -7 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +19 lines, -2 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +4 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
6 years, 4 months ago (2014-08-08 12:30:48 UTC) #1
titzer
lgtm, nice!
6 years, 4 months ago (2014-08-08 12:34:22 UTC) #2
Michael Starzinger
6 years, 4 months ago (2014-08-08 12:42:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 22997 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698