Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 450263002: Test <img crossorigin> handling of 401 responses. (Closed)

Created:
6 years, 4 months ago by sof
Modified:
6 years, 4 months ago
CC:
blink-reviews, evn, Tom Sepez
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Test <img crossorigin> handling of 401 responses. A CORS-enabled fetch to a resource that isn't CORS enabled, but returns a 401 should fail without offering up a UA dialog to supply credentials. Blink already implements this; add test coverage over <img>. R= BUG=239918 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179834

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
A LayoutTests/http/tests/security/img-crossorigin-no-credentials-prompt.html View 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/security/img-crossorigin-no-credentials-prompt-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/security/resources/img-basic-auth.php View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
Please take a look. The behavior that the associated bug requests has already been implemented ...
6 years, 4 months ago (2014-08-08 12:25:36 UTC) #1
Mike West
LGTM, thanks for adding these tests.
6 years, 4 months ago (2014-08-08 13:03:08 UTC) #2
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 4 months ago (2014-08-08 13:03:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/450263002/1
6 years, 4 months ago (2014-08-08 13:03:41 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-08 14:35:57 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 14:44:46 UTC) #6
Message was sent while issue was closed.
Change committed as 179834

Powered by Google App Engine
This is Rietveld 408576698