Prevent making real DNS lookups by chrome tests.

Prevent making real DNS lookups by chrome tests.

- by default a test which makes external DNS lookup directly or indirectly will fail

- added a quite simple way to allow a test to make external queries

- added a way to make external queries fail (for tests which don't need them to succeed but it's hard to not make the query)

- made neccessary adjustments to existing tests so that they still pass

http://crbug.com/9109

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12653

[Paweł Hajdan Jr., 2009-03-23 20:00:57]

Please review:

darin: main review
aa: extensions-related part (I'm not sure where it does the dns lookup of
google.com, and if it's necessary)

One problem I see with this patch is that HostMapper gets again more
complicated. :-/ I tried to keep it as simple as I could, but maybe it can be
done better, or is not worth the complication, or maybe you have some idea for
better approach.

Just allowing some tests to make external dns lookups instead of simulating
failed queries in HostMapper infrastructure would remove the need for
complication.

[Paweł Hajdan Jr., 2009-03-24 10:30:22]

ping.

Just a note about HostMapper and simulating failing lookups. I added it to fix
http://crbug.com/9109.

[darin (slow to review), 2009-03-24 20:10:20]

LG, but...

http://codereview.chromium.org/45026/diff/1/5
File chrome/test/unit/chrome_test_suite.h (right):

http://codereview.chromium.org/45026/diff/1/5#newcode33
Line 33: const char* local_hostnames[] = {"localhost", "127.0.0.1"};
nit: should probably be kLocalHostNames

http://codereview.chromium.org/45026/diff/1/7
File net/base/host_resolver.h (right):

http://codereview.chromium.org/45026/diff/1/7#newcode63
Line 63: const bool failure;  // True means "simulate failed dns lookup".
Q: couldn't you also use an empty host to indicate a failure?

[Paweł Hajdan Jr., 2009-03-25 12:54:50]

On 2009/03/24 20:10:20, darin wrote:
> LG, but...
> 
> http://codereview.chromium.org/45026/diff/1/5
> File chrome/test/unit/chrome_test_suite.h (right):
> 
> http://codereview.chromium.org/45026/diff/1/5#newcode33
> Line 33: const char* local_hostnames[] = {"localhost", "127.0.0.1"};
> nit: should probably be kLocalHostNames

Fixed.

> http://codereview.chromium.org/45026/diff/1/7
> File net/base/host_resolver.h (right):
> 
> http://codereview.chromium.org/45026/diff/1/7#newcode63
> Line 63: const bool failure;  // True means "simulate failed dns lookup".
> Q: couldn't you also use an empty host to indicate a failure?

Indeed, that simplifies the code a bit. Done.

[Aaron Boodman, 2009-03-25 22:59:39]

LGTM

[darin (slow to review), 2009-03-26 17:04:32]

LGTM