Issue 45019: Bug 6474: Rename the Cancel button to Close in Clear Browsing Data....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 45019: Bug 6474: Rename the Cancel button to Close in Clear Browsing Data.... (Closed)

Created:
11 years, 9 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Bug 6474: Rename the Cancel button to Close in Clear Browsing Data. At one point we changed the Clear Browsing Data dialog to remember the values of the combobox and the checkboxes between runs. Like with the Options dialog, changes you make take effect immediately and as such having a Cancel button is misleading. Therefore, I am proposing we rename it to Close. BUG=6474 TEST=Open Clear Browsing Data dialog. The button should now say Close. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12248

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome/app/generated_resources.grd	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/views/clear_browsing_data.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Finnur

11 years, 9 months ago (2009-03-20 22:51:40 UTC) #1

I wanted to move the IDS_CLOSE under generic terms, but was afraid it might
trigger a localization frenzy. :)

Expand Messages | Collapse Messages