Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issue 45019: Bug 6474: Rename the Cancel button to Close in Clear Browsing Data.... (Closed)

Created:
11 years, 9 months ago by Finnur
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Bug 6474: Rename the Cancel button to Close in Clear Browsing Data. At one point we changed the Clear Browsing Data dialog to remember the values of the combobox and the checkboxes between runs. Like with the Options dialog, changes you make take effect immediately and as such having a Cancel button is misleading. Therefore, I am proposing we rename it to Close. BUG=6474 TEST=Open Clear Browsing Data dialog. The button should now say Close. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12248

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/views/clear_browsing_data.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Finnur
11 years, 9 months ago (2009-03-20 22:51:40 UTC) #1
I wanted to move the IDS_CLOSE under generic terms, but was afraid it might
trigger a localization frenzy. :)

Powered by Google App Engine
This is Rietveld 408576698