Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 450183002: Add instance counters of Resource and AudioNode, and expose them via WebLeakDetector. (Closed)

Created:
6 years, 4 months ago by tkent
Modified:
6 years, 4 months ago
Reviewers:
kouhei (in TOK)
CC:
blink-reviews, jamesr, abarth-chromium, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin, Raymond Toy
Project:
blink
Visibility:
Public.

Description

Add instance counters of Resource and AudioNode, and expose them via WebLeakDetector. BUG=400588 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179845

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M Source/core/fetch/Resource.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/fetch/Resource.cpp View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/modules/webaudio/AudioNode.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/webaudio/AudioNode.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/web/WebLeakDetector.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M public/web/WebLeakDetector.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
Please review this.
6 years, 4 months ago (2014-08-08 05:51:41 UTC) #1
kouhei (in TOK)
lgtm lgtm w/ a note. Resource is not forced to be collected when Document goes ...
6 years, 4 months ago (2014-08-08 16:10:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/450183002/1
6 years, 4 months ago (2014-08-08 16:11:31 UTC) #3
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 17:08:25 UTC) #4
Message was sent while issue was closed.
Change committed as 179845

Powered by Google App Engine
This is Rietveld 408576698