Issue 450103004: Reland "More lazy deoptimization in Turbofan (binops, loads/stores)"

Issue 450103004: Reland "More lazy deoptimization in Turbofan (binops, loads/stores)" (Closed)

Created:
6 years, 4 months ago by Jarin

Modified:
6 years, 4 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Reland "More lazy deoptimization in Turbofan (binops, loads/stores)" This relands commit r23029 + adds missing lazy deopts for JSAdd operator inside VisitForInStatement. The added lazy deopt still refers to a bogus bailout id, but at least the graphs can be scheduled. BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23033

Patch Set 1 : Original CL (r23029) #

Patch Set 2 : Add missing deopts (still with invalid bailout id) #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+351 lines, -89 lines)			Patch
M	src/compiler/arm/linkage-arm.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/compiler/arm64/linkage-arm64.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/compiler/ast-graph-builder.h	View		8 chunks	+19 lines, -9 lines	0 comments	Download
M	src/compiler/ast-graph-builder.cc	View	1	41 chunks	+113 lines, -33 lines	0 comments	Download
M	src/compiler/code-generator.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/compiler/ia32/linkage-ia32.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/compiler/js-generic-lowering.cc	View		5 chunks	+16 lines, -9 lines	0 comments	Download
M	src/compiler/js-operator.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/linkage.h	View		1 chunk	+7 lines, -2 lines	0 comments	Download
M	src/compiler/linkage.cc	View		2 chunks	+10 lines, -1 line	0 comments	Download
M	src/compiler/linkage-impl.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/compiler/operator-properties-inl.h	View		3 chunks	+50 lines, -10 lines	0 comments	Download
M	src/compiler/register-allocator.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/register-allocator.cc	View		2 chunks	+66 lines, -0 lines	0 comments	Download
M	src/compiler/x64/linkage-x64.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/deoptimizer.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/objects.cc	View		4 chunks	+24 lines, -5 lines	0 comments	Download
M	test/cctest/cctest.status	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	test/cctest/compiler/test-scheduler.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/cctest/test-deoptimization.cc	View		16 chunks	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jarin

Could you take another look, please? (It is a tiny diff from the previous attempt.)

6 years, 4 months ago (2014-08-11 12:00:03 UTC) #1

Jarin

6 years, 4 months ago (2014-08-11 12:26:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as 23033 (presubmit successful).

Expand Messages | Collapse Messages