Refactor MIME type related methods in XHR for readability

Refactor MIME type related methods in XHR for readability

- Give more descriptive names to MIME type related methods
- Split responseMIMEType() into one without fallback to text/xml and one
  with it as this fallback is requird only a few places
- Add some FIXMEs to address issues found during this refactoring later

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179950

[sof, 2014-08-11 12:19:38]

https://codereview.chromium.org/450103003/diff/40001/Source/core/xml/XMLHttpR...
File Source/core/xml/XMLHttpRequest.cpp (right):

https://codereview.chromium.org/450103003/diff/40001/Source/core/xml/XMLHttpR...
Source/core/xml/XMLHttpRequest.cpp:192: AtomicString mimeType = finalMIMEType();
Shouldn't this be finalMIMETypeWithFallback() for the benefit of setMimeType()
further down?

https://codereview.chromium.org/450103003/diff/40001/Source/core/xml/XMLHttpR...
File Source/core/xml/XMLHttpRequest.h (right):

https://codereview.chromium.org/450103003/diff/40001/Source/core/xml/XMLHttpR...
Source/core/xml/XMLHttpRequest.h:171: AtomicString finalMIMEType() const;
The term "final MIME type" is a relatively obscure spec-internal name and
doesn't impart much to the general reader; can't we do better?
finalResponseMIMEType() ?

https://codereview.chromium.org/450103003/diff/40001/Source/core/xml/XMLHttpR...
Source/core/xml/XMLHttpRequest.h:237: String m_finalCharset;
Same comment re: name -- m_finalResponseCharset?

[tyoshino (SeeGerritForStatus), 2014-08-11 13:10:46]

Thanks

https://codereview.chromium.org/450103003/diff/40001/Source/core/xml/XMLHttpR...
File Source/core/xml/XMLHttpRequest.cpp (right):

https://codereview.chromium.org/450103003/diff/40001/Source/core/xml/XMLHttpR...
Source/core/xml/XMLHttpRequest.cpp:192: AtomicString mimeType = finalMIMEType();
On 2014/08/11 12:19:37, sof wrote:
> Shouldn't this be finalMIMETypeWithFallback() for the benefit of setMimeType()
> further down?

Wow, good catch! Done.

https://codereview.chromium.org/450103003/diff/40001/Source/core/xml/XMLHttpR...
File Source/core/xml/XMLHttpRequest.h (right):

https://codereview.chromium.org/450103003/diff/40001/Source/core/xml/XMLHttpR...
Source/core/xml/XMLHttpRequest.h:171: AtomicString finalMIMEType() const;
On 2014/08/11 12:19:38, sof wrote:
> The term "final MIME type" is a relatively obscure spec-internal name and
> doesn't impart much to the general reader; can't we do better?
> finalResponseMIMEType() ?

OK. Fixed

https://codereview.chromium.org/450103003/diff/40001/Source/core/xml/XMLHttpR...
Source/core/xml/XMLHttpRequest.h:237: String m_finalCharset;
On 2014/08/11 12:19:38, sof wrote:
> Same comment re: name -- m_finalResponseCharset?

Done

[sof, 2014-08-11 13:15:59]

lgtm

[tyoshino (SeeGerritForStatus), 2014-08-11 13:22:08]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2014-08-11 13:22:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tyoshino@chromium.org/450103003/60001

[commit-bot: I haz the power, 2014-08-11 14:19:53]

Change committed as 179950