Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 450093002: Cleanup: Remove obsolete references to webkit_glue namespace. (Closed)

Created:
6 years, 4 months ago by tfarina
Modified:
6 years, 4 months ago
CC:
chromium-reviews, jam, rouslan+spellwatch_chromium.org, dcheng, rlp+watch_chromium.org, groby+spellwatch_chromium.org, darin-cc_chromium.org, groby-ooo-7-16
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove obsolete references to webkit_glue namespace. BUG=338338 TEST=None R=groby@chromium.org,avi@chromium.org,sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288513

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M chrome/renderer/spellchecker/spellcheck_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_process.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/child/fling_animator_impl_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/threaded_data_provider.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/base/clipboard/scoped_clipboard_writer.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tfarina
groby -> chrome/renderer/spellchecker avi -> content/child sky -> ui/base/clipboard
6 years, 4 months ago (2014-08-08 02:34:34 UTC) #1
Avi (use Gerrit)
Haha, awesome. LGTM!
6 years, 4 months ago (2014-08-08 14:45:17 UTC) #2
sky
LGTM
6 years, 4 months ago (2014-08-08 16:28:49 UTC) #3
tfarina
groby -> thestig Although, sky already covers chrome/renderer with chrome/OWNERS.
6 years, 4 months ago (2014-08-08 19:54:18 UTC) #4
Lei Zhang
chrome/ lgtm
6 years, 4 months ago (2014-08-08 19:56:45 UTC) #5
tfarina
On 2014/08/08 19:56:45, Lei Zhang wrote: > chrome/ lgtm Thanks!
6 years, 4 months ago (2014-08-08 19:57:16 UTC) #6
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-08-08 19:57:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/450093002/1
6 years, 4 months ago (2014-08-08 20:02:18 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-09 05:37:15 UTC) #9
Message was sent while issue was closed. 
Change committed as 288513

Powered by Google App Engine
This is Rietveld 408576698