Throw exception on null pointers in raw toNative

Source/bindings/dart/custom/DartNodeCustom.cpp

 // Copyright 2011, Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //    * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //    * Redistributions in binary form must reproduce the above
@@ skipping 36 matching lines @@
 
 namespace DartNodeInternal {
 
 // This function is customized to take advantage of the optional 4th argument: shouldLazyAttach.
 void insertBeforeCallback(Dart_NativeArguments args)
 {
     Dart_Handle exception = 0;
     {
         Node* receiver = DartDOMWrapper::receiver<Node>(args);
 
-        Node* newChild = DartNode::toNative(args, 1, exception);
+        Node* newChild = DartNode::toNativeWithNullCheck(args, 1, exception);
         if (exception)
             goto fail;
 
-        Node* refChild = DartNode::toNative(args, 2, exception);
+        Node* refChild = DartNode::toNativeWithNullCheck(args, 2, exception);
         if (exception)
             goto fail;
 
         CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
 
         DartExceptionState es;
         receiver->insertBefore(newChild, refChild, es);
         if (es.hadException()) {
             exception = DartDOMWrapper::exceptionCodeToDartException(es);
             goto fail;
         }
 
         DartDOMWrapper::returnToDart<DartNode>(args, newChild);
         return;
     }
 
 fail:
     Dart_ThrowException(exception);
     ASSERT_NOT_REACHED();
 }
 
 // This function is customized to take advantage of the optional 4th argument: shouldLazyAttach.
 void replaceChildCallback(Dart_NativeArguments args)
 {
     Dart_Handle exception = 0;
     {
         Node* receiver = DartDOMWrapper::receiver<Node>(args);
 
-        Node* newChild = DartNode::toNative(args, 1, exception);
+        Node* newChild = DartNode::toNativeWithNullCheck(args, 1, exception);
         if (exception)
             goto fail;
 
-        Node* oldChild = DartNode::toNative(args, 2, exception);
+        Node* oldChild = DartNode::toNativeWithNullCheck(args, 2, exception);
         if (exception)
             goto fail;
 
         CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
 
         DartExceptionState es;
         receiver->replaceChild(newChild, oldChild, es);
         if (es.hadException()) {
             exception = DartDOMWrapper::exceptionCodeToDartException(es);
             goto fail;
         }
 
         DartDOMWrapper::returnToDart<DartNode>(args, newChild);
         return;
     }
 
 fail:
     Dart_ThrowException(exception);
     ASSERT_NOT_REACHED();
 }
 
 // Custom handling of the return value.
 void removeChildCallback(Dart_NativeArguments args)
 {
     Dart_Handle exception = 0;
     {
         Node* receiver = DartDOMWrapper::receiver<Node>(args);
 
-        Node* child = DartNode::toNative(args, 1, exception);
+        Node* child = DartNode::toNativeWithNullCheck(args, 1, exception);
         if (exception)
             goto fail;
 
         CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
 
         DartExceptionState es;
         receiver->removeChild(child, es);
         if (es.hadException()) {
             exception = DartDOMWrapper::exceptionCodeToDartException(es);
             goto fail;
         }
 
         DartDOMWrapper::returnToDart<DartNode>(args, child);
         return;
     }
 
 fail:
     Dart_ThrowException(exception);
     ASSERT_NOT_REACHED();
 }
 
 // This function is customized to enable lazy attaching - see the last argument to appendChild.
 void appendChildCallback(Dart_NativeArguments args)
 {
     Dart_Handle exception = 0;
     {
         Node* receiver = DartDOMWrapper::receiver<Node>(args);
 
-        Node* child = DartNode::toNative(args, 1, exception);
+        Node* child = DartNode::toNativeWithNullCheck(args, 1, exception);
         if (exception)
             goto fail;
 
         CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
 
         DartExceptionState es;
         receiver->appendChild(child, es);
         if (es.hadException()) {
             exception = DartDOMWrapper::exceptionCodeToDartException(es);
             goto fail;
@@ skipping 59 matching lines @@
     case Node::DOCUMENT_TYPE_NODE:
         return DartDocumentType::createWrapper(domData, static_cast<DocumentType*>(node));
     case Node::DOCUMENT_FRAGMENT_NODE:
         return DartDocumentFragment::createWrapper(domData, static_cast<DocumentFragment*>(node));
     default: break; // XPATH_NAMESPACE_NODE
     }
     return DartDOMWrapper::createWrapper<DartNode>(domData, node);
 }
 
 }