Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 450033: Rebaseline some tests. (Closed)

Created:
11 years ago by hamaji
Modified:
9 years, 5 months ago
Reviewers:
ukai
Visibility:
Public.

Description

Rebaseline some tests. LayoutTests/fast/repaint/list-marker.html LayoutTests/css2.1/t1205-c561-list-displ-00-b.html LayoutTests/css2.1/t1205-c565-list-pos-00-b.html LayoutTests/css2.1/t1205-c566-list-stl-00-e-ag.html They are marked as expected failures in http://codereview.chromium.org/454017 The list-marker one is a bit trickier than others. The position of texts after the list makers were wrong in expected image. However, it seems italic-styled character 'p' is lacking with the current test_shell and this is why it was marked as an expected failure. As its dump render tree result is correct, I've just rebaselined the text and added some comments on test_expectations.txt. Note that the following upstream change will fix the rest tests. https://bugs.webkit.org/show_bug.cgi?id=32014 BUG=28183 TEST=trybots

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -24 lines) Patch
M webkit/data/layout_tests/platform/chromium-linux/LayoutTests/css2.1/t1205-c561-list-displ-00-b-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-linux/LayoutTests/css2.1/t1205-c561-list-displ-00-b-expected.png View Binary file 0 comments Download
M webkit/data/layout_tests/platform/chromium-linux/LayoutTests/css2.1/t1205-c565-list-pos-00-b-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-linux/LayoutTests/css2.1/t1205-c565-list-pos-00-b-expected.png View Binary file 0 comments Download
M webkit/data/layout_tests/platform/chromium-linux/LayoutTests/css2.1/t1205-c566-list-stl-00-e-ag-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-linux/LayoutTests/css2.1/t1205-c566-list-stl-00-e-ag-expected.png View Binary file 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/css2.1/t1205-c561-list-displ-00-b-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/css2.1/t1205-c561-list-displ-00-b-expected.png View Binary file 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/css2.1/t1205-c561-list-displ-00-b-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/css2.1/t1205-c565-list-pos-00-b-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/css2.1/t1205-c565-list-pos-00-b-expected.png View Binary file 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/css2.1/t1205-c565-list-pos-00-b-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/css2.1/t1205-c566-list-stl-00-e-ag-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/css2.1/t1205-c566-list-stl-00-e-ag-expected.png View Binary file 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/css2.1/t1205-c566-list-stl-00-e-ag-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/list-marker-expected.txt View 2 chunks +4 lines, -6 lines 0 comments Download
M webkit/tools/layout_tests/test_expectations.txt View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
hamaji
Ukai-san, could you review this tomorrow if all bots become green?
11 years ago (2009-12-01 12:05:04 UTC) #1
ukai
11 years ago (2009-12-02 04:11:42 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698