Issue 450023002: Fix screen capture notification UI on Chrome OS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 450023002: Fix screen capture notification UI on Chrome OS. (Closed)

Created:
6 years, 4 months ago by hshi1

Modified:
6 years, 4 months ago

Reviewers:
Lei Zhang, Sergey Ulanov

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Fix screen capture notification UI on Chrome OS. The stub class should only be built for Android, not Chrome OS. BUG=401791 TEST=verify that screen capture notification UI is shown on ChromeOS. R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288174

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -12 lines)			Patch
	M	chrome/browser/ui/BUILD.gn	View	1 2	1 chunk	+0 lines, -5 lines	0 comments	Download
	M	chrome/chrome_browser_ui.gypi	View	1	3 chunks	+1 line, -7 lines	0 comments	Download

Total messages: 7 (0 generated)

hshi1

FYI this is to fix a problem caused by https://codereview.chromium.org/353013006 where the stub file for ...

6 years, 4 months ago (2014-08-07 23:59:10 UTC) #1

Lei Zhang

Doh. You need to fix chrome/browser/ui/BUILD.gn as well.

6 years, 4 months ago (2014-08-08 00:06:15 UTC) #3

hshi1

On 2014/08/08 00:06:15, Lei Zhang wrote: > Doh. You need to fix chrome/browser/ui/BUILD.gn as well. ...

6 years, 4 months ago (2014-08-08 00:08:35 UTC) #4

hshi1

6 years, 4 months ago (2014-08-08 00:28:02 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 manually as 288174 (presubmit successful).