Issue 450006: Finish merging r32589 from the trunk to the 249 branch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 450006: Finish merging r32589 from the trunk to the 249 branch (Closed)

Created:
11 years ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman, Bons

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/branches/249/src/

Visibility:
Public.

Description

Finish merging r32589 from the trunk to the 249 branch. r33261 merged most of r32589 to the 249 branch, but was incomplete. The changes to chrome/chrome.gyp were missing, and those changes were critical because r32589 adds new files. BUG=23881 TEST=249 branch is buildable. No link errors. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33275

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/chrome.gyp	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years ago (2009-11-30 07:13:17 UTC) #1

Oops.

TBR (broken build, don't want to go another day without a working249 nightly.)

Expand Messages | Collapse Messages