Pass display names for uploaded content URI files

android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.android_webview;
 
+import android.content.ContentResolver;
+import android.content.Context;
+import android.net.Uri;
 import android.os.Handler;
 import android.os.Message;
 import android.util.Log;
 import android.view.KeyEvent;
 import android.view.View;
 import android.webkit.ConsoleMessage;
 import android.webkit.ValueCallback;
 
+import org.chromium.base.ContentUriUtils;
 import org.chromium.base.ThreadUtils;
 import org.chromium.content.browser.ContentVideoView;
 import org.chromium.content.browser.ContentViewCore;
 
 /**
  * Adapts the AwWebContentsDelegate interface to the AwContentsClient interface.
  * This class also serves a secondary function of routing certain callbacks from the content layer
  * to specific listener interfaces.
  */
 class AwWebContentsDelegateAdapter extends AwWebContentsDelegate {
     private static final String TAG = "AwWebContentsDelegateAdapter";
 
     final AwContentsClient mContentsClient;
     View mContainerView;
+    final Context mContext;
 
     public AwWebContentsDelegateAdapter(AwContentsClient contentsClient,
-            View containerView) {
+            View containerView, Context context) {
         mContentsClient = contentsClient;
         setContainerView(containerView);
+        mContext = context;
     }
 
     public void setContainerView(View containerView) {
         mContainerView = containerView;
     }
 
     @Override
     public void onLoadProgressChanged(int progress) {
         mContentsClient.onProgressChanged(progress);
     }
@@ skipping 127 matching lines @@
         params.capture = capture;
 
         mContentsClient.showFileChooser(new ValueCallback<String[]>() {
             boolean mCompleted = false;
             @Override
             public void onReceiveValue(String[] results) {
                 if (mCompleted) {
                     throw new IllegalStateException("Duplicate showFileChooser result");
                 }
                 mCompleted = true;
-                nativeFilesSelectedInChooser(processId, renderId, mode_flags, results);
+                if (results == null) {
+                    nativeFilesSelectedInChooser(
+                            processId, renderId, mode_flags, null, null);
+                    return;
+                }
+                String[] displayNames = new String[results.length];
+                for (int i = 0; i < results.length; ++i) {
+                    displayNames[i] = resolveFileName(results[i]);
+                }
+                nativeFilesSelectedInChooser(
+                        processId, renderId, mode_flags, results, displayNames);
             }
         }, params);
     }
 
     @Override
     public boolean addNewContents(boolean isDialog, boolean isUserGesture) {
         return mContentsClient.onCreateWindow(isDialog, isUserGesture);
     }
 
     @Override
     public void activateContents() {
         mContentsClient.onRequestFocus();
     }
 
     @Override
     public void toggleFullscreenModeForTab(boolean enterFullscreen) {
         if (!enterFullscreen) {
             ContentVideoView videoView = ContentVideoView.getContentVideoView();
             if (videoView != null) videoView.exitFullscreen(false);
         }
     }
+
+    /**
+     * @return the display name of a path if it is a content URI and is present in the database
+     * or an empty string otherwise.
+     */
+    private String resolveFileName(String filePath) {
+        // Querying the ContentResolver on the UI thread may introduce extra latency.
+        // However, that is incomparable to the latency introduce by user interaction

[boliu, 2014/08/11 19:58:14]

That's a bad argument, because this delay is *after* waiting for user, not
*while* waiting for user.

[sgurun-gerrit only, 2014/08/11 21:23:24]

agreed with Bo. This is after user already chose the value, let's not increase
any jank on UI thread. 
Please use an asynctask. An asynctask does the processing in a background thread
and publishes the result in a UI thread, which then simply can call this.

On 2014/08/11 19:58:14, boliu wrote:

[qinmin, 2014/08/11 22:49:29]

Ok, moved all the contentResolver queries to an async task.

On 2014/08/11 21:23:24, sgurun wrote:

+        // with the select file dialog.
+        // TODO(qinmin): Run an async task to resolve all the file names, and pass
+        // the result back to the UI thread to run nativeFilesSelectedInChooser.
+        ContentResolver contentResolver = mContext.getContentResolver();
+        if (contentResolver == null || filePath == null) return "";
+        Uri uri = Uri.parse(filePath);
+        return ContentUriUtils.getDisplayName(uri, contentResolver);
+    }
 }