chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator_unittest.cc - Issue 449973002: Use data reduction proxy when managed proxy config returns direct

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator_unittest.cc

Issue 449973002: Use data reduction proxy when managed proxy config returns direct (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-uma-in-proxy-service

Patch Set: Addressed comment and nit Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator.cc ('K') | « chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator.cc ('k') | chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h » ('j') | chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator_unittest.cc

diff --git a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator_unittest.cc b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator_unittest.cc

index eb56ef5d4262427e993a2e3cd258164d8625903a..06848fa2102af08b986dfc3abe8001758ae6b0d9 100644

--- a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator_unittest.cc

+++ b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator_unittest.cc

@@ -9,6 +9,7 @@

#include "base/memory/scoped_ptr.h"

#include "base/prefs/pref_registry_simple.h"

#include "base/prefs/testing_pref_service.h"

+#include "base/test/test_simple_task_runner.h"

#include "base/values.h"

#include "chrome/common/pref_names.h"

#include "testing/gmock/include/gmock/gmock.h"

@@ -19,7 +20,9 @@ class DataReductionProxyConfigTest : public testing::Test {

virtual void SetUp() {

PrefRegistrySimple* registry = pref_service_.registry();

registry->RegisterDictionaryPref(prefs::kProxy);

- config_.reset(new DataReductionProxyChromeConfigurator(&pref_service_));

+ config_.reset(new DataReductionProxyChromeConfigurator(

+ &pref_service_,

+ new base::TestSimpleTaskRunner()));

}

void CheckProxyConfig(