Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4860)

Unified Diff: chrome/browser/net/chrome_network_delegate.cc

Issue 449973002: Use data reduction proxy when managed proxy config returns direct (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-uma-in-proxy-service
Patch Set: Addressed comment and nit Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/chrome_network_delegate.cc
diff --git a/chrome/browser/net/chrome_network_delegate.cc b/chrome/browser/net/chrome_network_delegate.cc
index 3d0f1b62094f43b673b08e6e476bc14a16313171..37683b033b47f9bc1da005ccf1afca2204f70ca9 100644
--- a/chrome/browser/net/chrome_network_delegate.cc
+++ b/chrome/browser/net/chrome_network_delegate.cc
@@ -47,7 +47,9 @@
#include "net/cookies/cookie_options.h"
#include "net/http/http_request_headers.h"
#include "net/http/http_response_headers.h"
+#include "net/proxy/proxy_config.h"
#include "net/proxy/proxy_info.h"
+#include "net/proxy/proxy_retry_info.h"
#include "net/proxy/proxy_server.h"
#include "net/socket_stream/socket_stream.h"
#include "net/url_request/url_request.h"
@@ -427,9 +429,15 @@ int ChromeNetworkDelegate::OnBeforeURLRequest(
}
void ChromeNetworkDelegate::OnResolveProxy(
- const GURL& url, int load_flags, net::ProxyInfo* result) {
- if (!on_resolve_proxy_handler_.is_null()) {
+ const GURL& url,
+ int load_flags,
+ const net::ProxyService& proxy_service,
+ net::ProxyInfo* result) {
+ if (!on_resolve_proxy_handler_.is_null() &&
+ !proxy_config_getter_.is_null()) {
Ryan Sleevi 2014/08/14 19:19:50 Is this correct? It now forces proxy_config_getter
on_resolve_proxy_handler_.Run(url, load_flags,
+ proxy_config_getter_.Run(),
+ proxy_service.proxy_retry_info(),
data_reduction_proxy_params_, result);
}
}

Powered by Google App Engine
This is Rietveld 408576698