Use data reduction proxy when managed proxy config returns direct

net/base/network_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_NETWORK_DELEGATE_H_
 #define NET_BASE_NETWORK_DELEGATE_H_
 
 #include <string>
 
 #include "base/callback.h"
@@ skipping 19 matching lines @@
 // levels, we may encounter dangerous casting issues.
 //
 // NOTE: It is not okay to add any compile-time dependencies on symbols outside
 // of net/base here, because we have a net_base library. Forward declarations
 // are ok.
 class CookieOptions;
 class HttpRequestHeaders;
 class HttpResponseHeaders;
 class ProxyInfo;
 class ProxyServer;
+class ProxyService;
 class SocketStream;
 class URLRequest;
 
 class NET_EXPORT NetworkDelegate : public base::NonThreadSafe {
  public:
   // AuthRequiredResponse indicates how a NetworkDelegate handles an
   // OnAuthRequired call. It's placed in this file to prevent url_request.h
   // from having to include network_delegate.h.
   enum AuthRequiredResponse {
     AUTH_REQUIRED_RESPONSE_NO_ACTION,
     AUTH_REQUIRED_RESPONSE_SET_AUTH,
     AUTH_REQUIRED_RESPONSE_CANCEL_AUTH,
     AUTH_REQUIRED_RESPONSE_IO_PENDING,
   };
   typedef base::Callback<void(AuthRequiredResponse)> AuthCallback;
 
   virtual ~NetworkDelegate() {}
 
   // Notification interface called by the network stack. Note that these
   // functions mostly forward to the private virtuals. They also add some sanity
   // checking on parameters. See the corresponding virtuals for explanations of
   // the methods and their arguments.
   int NotifyBeforeURLRequest(URLRequest* request,
                              const CompletionCallback& callback,
                              GURL* new_url);
-  void NotifyResolveProxy(const GURL& url, int load_flags,
+  void NotifyResolveProxy(const GURL& url,
+                          int load_flags,
+                          const ProxyService& proxy_service,
                           ProxyInfo* result);
   void NotifyProxyFallback(const ProxyServer& bad_proxy,
                            int net_error,
                            bool did_fallback);
   int NotifyBeforeSendHeaders(URLRequest* request,
                               const CompletionCallback& callback,
                               HttpRequestHeaders* headers);
   void NotifyBeforeSendProxyHeaders(URLRequest* request,
                                     const ProxyInfo& proxy_info,
                                     HttpRequestHeaders* headers);
@@ skipping 46 matching lines @@
   // A status code other than OK and ERR_IO_PENDING will cancel the request and
   // report the status code as the reason.
   //
   // The default implementation returns OK (continue with request).
   virtual int OnBeforeURLRequest(URLRequest* request,
                                  const CompletionCallback& callback,
                                  GURL* new_url);
 
   // Called as the proxy is being resolved for |url|. Allows the delegate to
   // override the proxy resolution decision made by ProxyService. The delegate
   // may override the decision by modifying the ProxyInfo |result|.

[Ryan Sleevi, 2014/08/14 19:19:51]

Please update this documentation to reflect how proxy_service can and should be
used. I could not find documentation that spells it out, beyond the comments on
this review.

   virtual void OnResolveProxy(const GURL& url,
                               int load_flags,
+                              const ProxyService& proxy_service,
                               ProxyInfo* result);
 
   // Called when use of |bad_proxy| fails due to |net_error|. |did_fallback| is
   // true if the proxy service was able to fallback to another proxy
   // configuration.
   virtual void OnProxyFallback(const ProxyServer& bad_proxy,
                                int net_error,
                                bool did_fallback);
 
   // Called right before the HTTP headers are sent. Allows the delegate to
@@ skipping 120 matching lines @@
 
   // Called before a SocketStream tries to connect.
   // See OnBeforeURLRequest for return value description. Returns OK by default.
   virtual int OnBeforeSocketStreamConnect(
       SocketStream* socket, const CompletionCallback& callback);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_NETWORK_DELEGATE_H_