Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Side by Side Diff: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h

Issue 449973002: Use data reduction proxy when managed proxy config returns direct (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-uma-in-proxy-service
Patch Set: Addressed comment and nit Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_ 5 #ifndef CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_
6 #define CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_ 6 #define CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
Ryan Sleevi 2014/08/14 19:19:51 IWYU: This is no longer needed
9 #include "components/data_reduction_proxy/browser/data_reduction_proxy_settings. h" 9 #include "components/data_reduction_proxy/browser/data_reduction_proxy_settings. h"
10 #include "components/keyed_service/core/keyed_service.h" 10 #include "components/keyed_service/core/keyed_service.h"
11 11
12 namespace base { 12 namespace base {
13 class PrefService; 13 class PrefService;
14 } 14 }
15 15
16 namespace data_reduction_proxy { 16 namespace data_reduction_proxy {
17 class DataReductionProxyConfigurator; 17 class DataReductionProxyConfigurator;
18 class DataReductionProxyParams; 18 class DataReductionProxyParams;
(...skipping 15 matching lines...) Expand all
34 // Construction and destruction must happen on the UI thread. 34 // Construction and destruction must happen on the UI thread.
35 explicit DataReductionProxyChromeSettings( 35 explicit DataReductionProxyChromeSettings(
36 data_reduction_proxy::DataReductionProxyParams* params); 36 data_reduction_proxy::DataReductionProxyParams* params);
37 37
38 // Destructs the settings object. 38 // Destructs the settings object.
39 virtual ~DataReductionProxyChromeSettings(); 39 virtual ~DataReductionProxyChromeSettings();
40 40
41 // Initialize the settings object with the given configurator, prefs services, 41 // Initialize the settings object with the given configurator, prefs services,
42 // and request context. 42 // and request context.
43 void InitDataReductionProxySettings( 43 void InitDataReductionProxySettings(
44 scoped_ptr<data_reduction_proxy::DataReductionProxyConfigurator> 44 data_reduction_proxy::DataReductionProxyConfigurator* configurator,
45 configurator,
46 PrefService* profile_prefs, 45 PrefService* profile_prefs,
47 PrefService* local_state_prefs, 46 PrefService* local_state_prefs,
48 net::URLRequestContextGetter* request_context); 47 net::URLRequestContextGetter* request_context);
49 48
50 // Using the chrome::VersionInfo version, returns the build and patch portion 49 // Using the chrome::VersionInfo version, returns the build and patch portion
51 // of the string delimited by a period. If the chrome::VersionInfo version 50 // of the string delimited by a period. If the chrome::VersionInfo version
52 // isn't of the form xx.xx.xx.xx returns an empty string. 51 // isn't of the form xx.xx.xx.xx returns an empty string.
53 static std::string GetBuildAndPatchNumber(); 52 static std::string GetBuildAndPatchNumber();
54 53
55 // Gets the client type for the data reduction proxy. 54 // Gets the client type for the data reduction proxy.
56 static std::string GetClient(); 55 static std::string GetClient();
57 56
58 private: 57 private:
59 // Registers the DataReductionProxyEnabled synthetic field trial with 58 // Registers the DataReductionProxyEnabled synthetic field trial with
60 // the group |data_reduction_proxy_enabled|. 59 // the group |data_reduction_proxy_enabled|.
61 void RegisterSyntheticFieldTrial(bool data_reduction_proxy_enabled); 60 void RegisterSyntheticFieldTrial(bool data_reduction_proxy_enabled);
62 61
63 DISALLOW_COPY_AND_ASSIGN(DataReductionProxyChromeSettings); 62 DISALLOW_COPY_AND_ASSIGN(DataReductionProxyChromeSettings);
64 }; 63 };
65 64
66 #endif // CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_ 65 #endif // CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698