Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 449933002: change drawPicture in SkRecord to just ref the picture (Closed)

Created:
6 years, 4 months ago by reed1
Modified:
6 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

change drawPicture in SkRecord to just ref the picture also fix some int/unsigned/size_t warnings BUG=skia: Committed: https://skia.googlesource.com/skia/+/2347b624678fedf1d2f7ab1d79b9ad70087c3392

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -6 lines) Patch
M src/core/SkRecord.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRecordDraw.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkRecorder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRecorder.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkRecords.h View 3 chunks +20 lines, -0 lines 2 comments Download
M tests/RecorderTest.cpp View 1 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
reed1
6 years, 4 months ago (2014-08-07 18:13:37 UTC) #1
mtklein
lgtm https://codereview.chromium.org/449933002/diff/20001/src/core/SkRecords.h File src/core/SkRecords.h (right): https://codereview.chromium.org/449933002/diff/20001/src/core/SkRecords.h#newcode28 src/core/SkRecords.h:28: const SkPicture* fObj; SkAutoTUnref<const SkPicture> ?
6 years, 4 months ago (2014-08-07 18:19:27 UTC) #2
reed1
https://codereview.chromium.org/449933002/diff/20001/src/core/SkRecords.h File src/core/SkRecords.h (right): https://codereview.chromium.org/449933002/diff/20001/src/core/SkRecords.h#newcode28 src/core/SkRecords.h:28: const SkPicture* fObj; On 2014/08/07 18:19:27, mtklein wrote: > ...
6 years, 4 months ago (2014-08-07 19:10:52 UTC) #3
reed1
The CQ bit was checked by reed@google.com
6 years, 4 months ago (2014-08-07 19:10:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/449933002/20001
6 years, 4 months ago (2014-08-07 19:12:42 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 19:20:05 UTC) #6
Message was sent while issue was closed. 
Change committed as 2347b624678fedf1d2f7ab1d79b9ad70087c3392

Powered by Google App Engine
This is Rietveld 408576698