Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 44993003: [webcrypto] Make WebCryptoAlgorithm "nullable". (Closed)

Created:
7 years, 1 month ago by eroman
Modified:
7 years, 1 month ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, tommyw+watchlist_chromium.org, dglazkov+blink, abarth-chromium, padolph
Visibility:
Public.

Description

[webcrypto] Make WebCryptoAlgorithm "nullable". This makes it simpler on the embedder side to have helper functions which either create a WebCryptoAlgorithm or fail. It is also used for passing an optional WebCryptoAlgorithm in the WebCrypto::importKey() interface. BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160649

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -6 lines) Patch
M Source/core/platform/chromium/support/WebCryptoAlgorithm.cpp View 9 chunks +20 lines, -0 lines 0 comments Download
M Source/core/platform/chromium/support/WebCryptoKey.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M public/platform/WebCrypto.h View 1 chunk +6 lines, -0 lines 0 comments Download
M public/platform/WebCryptoAlgorithm.h View 3 chunks +6 lines, -0 lines 0 comments Download
M public/platform/WebCryptoAlgorithmParams.h View 6 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eroman
7 years, 1 month ago (2013-10-25 18:45:17 UTC) #1
abarth-chromium
lgtm
7 years, 1 month ago (2013-10-26 00:50:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/44993003/30001
7 years, 1 month ago (2013-10-26 00:50:32 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-10-26 01:53:59 UTC) #4
Message was sent while issue was closed.
Change committed as 160649

Powered by Google App Engine
This is Rietveld 408576698