Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 449923004: Views should not have third_party/wtl/include as an include directory on non-Windows builds. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

Views should not have third_party/wtl/include as an include directory on non-Windows builds. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288263

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M ui/views/views.gyp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
6 years, 4 months ago (2014-08-07 19:39:34 UTC) #1
sky
LGTM
6 years, 4 months ago (2014-08-07 21:19:37 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-07 21:24:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/449923004/1
6 years, 4 months ago (2014-08-07 21:41:24 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 08:43:06 UTC) #5
Message was sent while issue was closed.
Change committed as 288263

Powered by Google App Engine
This is Rietveld 408576698