Issue 449923003: Turn on harmony_unscopables for es_staging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 449923003: Turn on harmony_unscopables for es_staging (Closed)

Created:
6 years, 4 months ago by arv (Not doing code reviews)

Modified:
6 years, 4 months ago

Reviewers:
adamk, rossberg

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Turn on harmony_unscopables for es_staging BUG=v8:3401 LOG=Y R=adamk@chromium.org, rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22992

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/flag-definitions.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

adamk

https://codereview.chromium.org/449923003/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/449923003/diff/1/src/flag-definitions.h#newcode177 src/flag-definitions.h:177: DEFINE_implication(es_staging, harmony_unscopables) presumably this needs to be ALL CAPS?

6 years, 4 months ago (2014-08-07 18:17:02 UTC) #2

arv (Not doing code reviews)

On 2014/08/07 at 18:17:02, adamk wrote: > https://codereview.chromium.org/449923003/diff/1/src/flag-definitions.h > File src/flag-definitions.h (right): > > https://codereview.chromium.org/449923003/diff/1/src/flag-definitions.h#newcode177 ...

6 years, 4 months ago (2014-08-07 18:23:26 UTC) #3

rossberg

6 years, 4 months ago (2014-08-08 10:49:10 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as 22992 (presubmit successful).

Expand Messages | Collapse Messages

Issue 449923003: Turn on harmony_unscopables for es_staging (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages