Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2772)

Unified Diff: chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc

Issue 449913002: Add Ash.Wallpaper.{DefaultIndex,Type} to histograms.xml. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cosmetic fix. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h ('k') | components/user_manager/user.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
diff --git a/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc b/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
index e5c2b1dfdb2149c02fdddea45e03c40974919cb3..1bce55d7f5247c4bfbd7698dee033eb3e037f67d 100644
--- a/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
+++ b/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
@@ -531,8 +531,8 @@ void WallpaperManager::EnsureLoggedInUserWallpaperLoaded() {
WallpaperInfo info;
if (GetLoggedInUserWallpaperInfo(&info)) {
- // TODO(sschmitz): We need an index for default wallpapers for the new UI.
- RecordUma(info.type, -1);
+ UMA_HISTOGRAM_ENUMERATION("Ash.Wallpaper.Type", info.type,
+ user_manager::User::WALLPAPER_TYPE_COUNT);
if (info == current_user_wallpaper_info_)
return;
}
@@ -1008,13 +1008,6 @@ void WallpaperManager::DoSetDefaultWallpaper(
}
// static
-void WallpaperManager::RecordUma(user_manager::User::WallpaperType type,
- int index) {
- UMA_HISTOGRAM_ENUMERATION(
- "Ash.Wallpaper.Type", type, user_manager::User::WALLPAPER_TYPE_COUNT);
-}
-
-// static
void WallpaperManager::SaveCustomWallpaper(const std::string& user_id_hash,
const base::FilePath& original_path,
ash::WallpaperLayout layout,
« no previous file with comments | « chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h ('k') | components/user_manager/user.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698