components/user_manager/user.h - Issue 449913002: Add Ash.Wallpaper.{DefaultIndex,Type} to histograms.xml.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/user_manager/user.h

Issue 449913002: Add Ash.Wallpaper.{DefaultIndex,Type} to histograms.xml. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/user_manager/user.h

diff --git a/components/user_manager/user.h b/components/user_manager/user.h

index 006761db2048b81986672a18b1d2cbdf21f93cfb..23e8230bf25f5f2f9984a9400bd69a89d363f2de 100644

--- a/components/user_manager/user.h

+++ b/components/user_manager/user.h

@@ -60,12 +60,16 @@ class USER_MANAGER_EXPORT User : public UserInfo {

USER_IMAGE_EXTERNAL = -1,

} UserImageType;

+ // This enum is used to define the buckets for an enumerated UMA histogram.

+ // Hence,

+ // (a) existing enumerated constants should never be deleted or reordered,

+ // (b) new constants should only be appended at the end of the enumeration.

enum WallpaperType {

- /* DAILY = 0 */ // Removed. Do not re-use the id!

+ /* DAILY = 0 */ // Removed.

CUSTOMIZED = 1, // Selected by user.

DEFAULT = 2, // Default.

- /* UNKNOWN = 3 */ // Removed. Do not re-use the id!

- ONLINE = 4, // WallpaperInfo.file denotes an URL.

+ /* UNKNOWN = 3 */ // Removed.

+ ONLINE = 4, // WallpaperInfo.location denotes an URL.

POLICY = 5, // Controlled by policy, can't be changed by the user.

WALLPAPER_TYPE_COUNT = 6

};