Add Ash.Wallpaper.{DefaultIndex,Type} to histograms.xml.

Add Ash.Wallpaper.{DefaultIndex,Type} to histograms.xml.

Move them from internal histograms.xml to chromium.org histograms.xml since they are/were referenced only in chromium.org code.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288370

[Thiemo Nagel, 2014-08-07 17:15:24]

Hi Alexei, could you please take a look at histograms.xml?

Hi Nikita, could you please take a look at the rest?  I've assigned the
histogram to you, please let me know if you'd prefer somebody else.

Thank you and best regards,
Thiemo

[Alexei Svitkine (slow), 2014-08-07 18:36:50]

https://codereview.chromium.org/449913002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/449913002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:728: +  <summary>The wallpaper type.
Recorded at user login.</summary>
This histogram exists in the internal version of the histograms.xml file.

If you're adding it here, please also remove it from that version
(http://cs/chrome/histograms.xml)

[Thiemo Nagel, 2014-08-07 18:50:40]

Since the histogram already exists, I'm also keeping it's owner: kuscher@.

https://codereview.chromium.org/449913002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/449913002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:728: +  <summary>The wallpaper type.
Recorded at user login.</summary>
On 2014/08/07 18:36:50, Alexei Svitkine wrote:
> This histogram exists in the internal version of the histograms.xml file.

Thanks a lot!  I've been looking for it, without success.  (Why is that not part
of the src-internal checkout?)
 
> If you're adding it here, please also remove it from that version
> (http://cs/chrome/histograms.xml)

Ok, will do.  Shall I add it first or remove it first?

[Alexei Svitkine (slow), 2014-08-07 19:04:29]

We've recently moved the file to google3 out of src-internal (which allows
us to automate a manual step in updating these and also is a more
convenient workflow for making changes - e.g. can be done through a web
UI). You can send a parallel CL to remove it from there, but it doesn't
have to block this one.


On Thu, Aug 7, 2014 at 2:50 PM, <tnagel@chromium.org> wrote:

> Since the histogram already exists, I'm also keeping it's owner: kuscher@.
>
>
>
> https://codereview.chromium.org/449913002/diff/1/tools/
> metrics/histograms/histograms.xml
> File tools/metrics/histograms/histograms.xml (right):
>
> https://codereview.chromium.org/449913002/diff/1/tools/
> metrics/histograms/histograms.xml#newcode728
> tools/metrics/histograms/histograms.xml:728: +  <summary>The wallpaper
> type. Recorded at user login.</summary>
> On 2014/08/07 18:36:50, Alexei Svitkine wrote:
>
>> This histogram exists in the internal version of the histograms.xml
>>
> file.
>
> Thanks a lot!  I've been looking for it, without success.  (Why is that
> not part of the src-internal checkout?)
>
>
>  If you're adding it here, please also remove it from that version
>> (http://cs/chrome/histograms.xml)
>>
>
> Ok, will do.  Shall I add it first or remove it first?
>
> https://codereview.chromium.org/449913002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Thiemo Nagel, 2014-08-07 19:13:57]

On 2014/08/07 19:04:29, Alexei Svitkine wrote:
> We've recently moved the file to google3 out of src-internal (which allows
> us to automate a manual step in updating these and also is a more
> convenient workflow for making changes - e.g. can be done through a web
> UI). You can send a parallel CL to remove it from there, but it doesn't
> have to block this one.

Thanks.  I've created a google3 CL to remove this histogram (and another unused
one) from the internal histograms.xml file.

[Alexei Svitkine (slow), 2014-08-07 20:54:54]

LGTM

[Nikita (slow), 2014-08-08 12:55:33]

lgtm

[Thiemo Nagel, 2014-08-08 13:14:42]

On 2014/08/08 12:55:33, Nikita Kostylev wrote:
> lgtm

Thank you!

[Thiemo Nagel, 2014-08-08 13:14:47]

The CQ bit was checked by tnagel@chromium.org

[commit-bot: I haz the power, 2014-08-08 13:14:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tnagel@chromium.org/449913002/60001

[commit-bot: I haz the power, 2014-08-08 16:03:47]

Change committed as 288370