Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 449893002: DevTools: Introduce ThreadsSidebar (Closed)

Created:
6 years, 4 months ago by sergeyv
Modified:
6 years, 4 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Introduce ThreadsSidebar BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179827

Patch Set 1 #

Patch Set 2 : Fix visibility #

Total comments: 8

Patch Set 3 : Address vsevik's comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -10 lines) Patch
M Source/devtools/devtools.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 1 2 10 chunks +34 lines, -9 lines 0 comments Download
A Source/devtools/front_end/sources/ThreadsSidebarPane.js View 1 2 1 chunk +108 lines, -0 lines 1 comment Download
M Source/devtools/front_end/ui/SidebarPane.js View 1 2 2 chunks +17 lines, -1 line 0 comments Download
M Source/devtools/scripts/frontend_modules.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sergeyv
6 years, 4 months ago (2014-08-07 15:45:51 UTC) #1
vsevik
https://chromiumcodereview.appspot.com/449893002/diff/20001/Source/devtools/front_end/sources/SourcesPanel.js File Source/devtools/front_end/sources/SourcesPanel.js (right): https://chromiumcodereview.appspot.com/449893002/diff/20001/Source/devtools/front_end/sources/SourcesPanel.js#newcode1163 Source/devtools/front_end/sources/SourcesPanel.js:1163: this._sidebarPaneStack.toggleHidden(this.sidebarPanes.threads, WebInspector.targetManager.targets().length < 2); togglePaneHidden https://chromiumcodereview.appspot.com/449893002/diff/20001/Source/devtools/front_end/sources/ThreadsSidebarPane.js File Source/devtools/front_end/sources/ThreadsSidebarPane.js (right): ...
6 years, 4 months ago (2014-08-08 08:32:03 UTC) #2
sergeyv
https://codereview.chromium.org/449893002/diff/20001/Source/devtools/front_end/sources/SourcesPanel.js File Source/devtools/front_end/sources/SourcesPanel.js (right): https://codereview.chromium.org/449893002/diff/20001/Source/devtools/front_end/sources/SourcesPanel.js#newcode1163 Source/devtools/front_end/sources/SourcesPanel.js:1163: this._sidebarPaneStack.toggleHidden(this.sidebarPanes.threads, WebInspector.targetManager.targets().length < 2); On 2014/08/08 08:32:03, vsevik wrote: ...
6 years, 4 months ago (2014-08-08 09:01:51 UTC) #3
vsevik
lgtm https://codereview.chromium.org/449893002/diff/40001/Source/devtools/front_end/sources/ThreadsSidebarPane.js File Source/devtools/front_end/sources/ThreadsSidebarPane.js (right): https://codereview.chromium.org/449893002/diff/40001/Source/devtools/front_end/sources/ThreadsSidebarPane.js#newcode32 Source/devtools/front_end/sources/ThreadsSidebarPane.js:32: var placard = new WebInspector.Placard(WebInspector.displayNameForURL(target.name()), ""); Calling WebInspector.displayNameForURL("Main") ...
6 years, 4 months ago (2014-08-08 11:18:26 UTC) #4
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 4 months ago (2014-08-08 11:24:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/449893002/40001
6 years, 4 months ago (2014-08-08 11:25:19 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 12:48:50 UTC) #7
Message was sent while issue was closed. 
Change committed as 179827

Powered by Google App Engine
This is Rietveld 408576698