Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: chrome/browser/devtools/device/self_device_provider.cc

Issue 449883002: DevTools: Removed refcounting from AndroidWebSocket (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/devtools/device/self_device_provider.h" 5 #include "chrome/browser/devtools/device/self_device_provider.h"
6 6
7 #include "base/strings/string_number_conversions.h" 7 #include "base/strings/string_number_conversions.h"
8 #include "base/strings/stringprintf.h" 8 #include "base/strings/stringprintf.h"
9 #include "net/socket/tcp_client_socket.h" 9 #include "net/socket/tcp_client_socket.h"
10 10
11 namespace { 11 namespace {
12 12
13 const char kDeviceModel[] = "Local Chrome"; 13 const char kDeviceModel[] = "Local Chrome";
14 const char kBrowserName[] = "Chrome"; 14 const char kBrowserName[] = "Chrome";
15 const char kLocalhost[] = "127.0.0.1"; 15 const char kLocalhost[] = "127.0.0.1";
16 const char kSerial[] = "local"; 16 const char kSerial[] = "local";
17 17
18 static void RunSocketCallback( 18 static void RunSocketCallback(
19 const AndroidDeviceManager::SocketCallback& callback, 19 const AndroidDeviceManager::SocketCallback& callback,
20 net::StreamSocket* socket, 20 scoped_ptr<net::StreamSocket> socket,
21 int result) { 21 int result) {
22 callback.Run(result, socket); 22 callback.Run(result, socket.Pass());
23 } 23 }
24 24
25 } // namespace 25 } // namespace
26 26
27 SelfAsDeviceProvider::SelfAsDeviceProvider(int port) : port_(port) { 27 SelfAsDeviceProvider::SelfAsDeviceProvider(int port) : port_(port) {
28 } 28 }
29 29
30 void SelfAsDeviceProvider::QueryDevices(const SerialsCallback& callback) { 30 void SelfAsDeviceProvider::QueryDevices(const SerialsCallback& callback) {
31 std::vector<std::string> result; 31 std::vector<std::string> result;
32 result.push_back(kSerial); 32 result.push_back(kSerial);
(...skipping 21 matching lines...) Expand all
54 const std::string& socket_name, 54 const std::string& socket_name,
55 const SocketCallback& callback) { 55 const SocketCallback& callback) {
56 // Use plain socket for remote debugging and port forwarding on Desktop 56 // Use plain socket for remote debugging and port forwarding on Desktop
57 // (debugging purposes). 57 // (debugging purposes).
58 net::IPAddressNumber ip_number; 58 net::IPAddressNumber ip_number;
59 net::ParseIPLiteralToNumber(kLocalhost, &ip_number); 59 net::ParseIPLiteralToNumber(kLocalhost, &ip_number);
60 int port; 60 int port;
61 base::StringToInt(socket_name, &port); 61 base::StringToInt(socket_name, &port);
62 net::AddressList address_list = 62 net::AddressList address_list =
63 net::AddressList::CreateFromIPAddress(ip_number, port); 63 net::AddressList::CreateFromIPAddress(ip_number, port);
64 net::TCPClientSocket* socket = new net::TCPClientSocket( 64 scoped_ptr<net::StreamSocket> socket(new net::TCPClientSocket(
65 address_list, NULL, net::NetLog::Source()); 65 address_list, NULL, net::NetLog::Source()));
66 socket->Connect(base::Bind(&RunSocketCallback, callback, socket)); 66 socket->Connect(
67 base::Bind(&RunSocketCallback, callback, base::Passed(&socket)));
67 } 68 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698