Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: content/browser/renderer_host/input/gesture_event_filter.h

Issue 44983003: Events ignoring ack disposition receive synthetic acks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: jdduke comments. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/input/gesture_event_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/input/gesture_event_filter.h
diff --git a/content/browser/renderer_host/input/gesture_event_filter.h b/content/browser/renderer_host/input/gesture_event_filter.h
index 7ed57decd304289eb2127459ebf789b756e71ecd..c868405ca21d418ce027db2ee9e564f3749b9b8d 100644
--- a/content/browser/renderer_host/input/gesture_event_filter.h
+++ b/content/browser/renderer_host/input/gesture_event_filter.h
@@ -93,8 +93,6 @@ class CONTENT_EXPORT GestureEventFilter {
friend class MockRenderWidgetHost;
friend class GestureEventFilterTest;
- static bool ShouldIgnoreAckForGestureType(blink::WebInputEvent::Type type);
-
// TODO(mohsen): There are a bunch of ShouldForward.../ShouldDiscard...
// methods that are getting confusing. This should be somehow fixed. Maybe
// while refactoring GEF: http://crbug.com/148443.
@@ -152,11 +150,6 @@ class CONTENT_EXPORT GestureEventFilter {
gfx::Transform GetTransformForEvent(
const GestureEventWithLatencyInfo& gesture_event) const;
- // Pops and sends events ignoring ack from the head of
- // |coalesced_gesture_events_| until the queue is empty or the event at the
- // head requires an ack.
- void SendEventsIgnoringAck();
-
// Adds |gesture_event| to the |coalesced_gesture_events_|, resetting the
// accumulation of |combined_scroll_pinch_|.
void EnqueueEvent(const GestureEventWithLatencyInfo& gesture_event);
« no previous file with comments | « no previous file | content/browser/renderer_host/input/gesture_event_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698