Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4325)

Unified Diff: content/browser/renderer_host/input/gesture_event_filter.h

Issue 44983003: Events ignoring ack disposition receive synthetic acks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address jdduke's comments. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/gesture_event_filter.h
diff --git a/content/browser/renderer_host/input/gesture_event_filter.h b/content/browser/renderer_host/input/gesture_event_filter.h
index 7ed57decd304289eb2127459ebf789b756e71ecd..f46f0f3fd69aed720f9a30b9ca42085d9d877118 100644
--- a/content/browser/renderer_host/input/gesture_event_filter.h
+++ b/content/browser/renderer_host/input/gesture_event_filter.h
@@ -92,8 +92,7 @@ class CONTENT_EXPORT GestureEventFilter {
private:
friend class MockRenderWidgetHost;
friend class GestureEventFilterTest;
-
- static bool ShouldIgnoreAckForGestureType(blink::WebInputEvent::Type type);
+ friend class ImmediateInputRouterTest;
jdduke (slow) 2013/11/07 23:12:52 I think we can test sync ack behavior in the Immed
tdresser 2013/11/08 16:20:34 Done.
// TODO(mohsen): There are a bunch of ShouldForward.../ShouldDiscard...
// methods that are getting confusing. This should be somehow fixed. Maybe
@@ -152,11 +151,6 @@ class CONTENT_EXPORT GestureEventFilter {
gfx::Transform GetTransformForEvent(
const GestureEventWithLatencyInfo& gesture_event) const;
- // Pops and sends events ignoring ack from the head of
- // |coalesced_gesture_events_| until the queue is empty or the event at the
- // head requires an ack.
- void SendEventsIgnoringAck();
-
// Adds |gesture_event| to the |coalesced_gesture_events_|, resetting the
// accumulation of |combined_scroll_pinch_|.
void EnqueueEvent(const GestureEventWithLatencyInfo& gesture_event);

Powered by Google App Engine
This is Rietveld 408576698