Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 44983002: Devirtualize several mediastream class destructors (Closed)

Created:
7 years, 1 month ago by Inactive
Modified:
7 years, 1 month ago
CC:
blink-reviews, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Devirtualize several mediastream class destructors Devirtualize several mediastream class destructors as these classes are never subclassed, nor do they have any virtual method. This avoids creating unnecessary vtables. BUG=311561 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160619

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M Source/modules/mediastream/MediaStreamTrackSourcesRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/NavigatorUserMediaError.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCIceCandidate.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/mediastream/RTCIceCandidate.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/modules/mediastream/RTCSessionDescription.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/mediastream/RTCSessionDescription.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Inactive
7 years, 1 month ago (2013-10-25 18:07:17 UTC) #1
eseidel
lgtm Do these classes need FINAL as well, or are they completely sans-virtual at this ...
7 years, 1 month ago (2013-10-25 18:08:48 UTC) #2
Inactive
On 2013/10/25 18:08:48, eseidel wrote: > lgtm > > Do these classes need FINAL as ...
7 years, 1 month ago (2013-10-25 18:10:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/44983002/1
7 years, 1 month ago (2013-10-25 18:45:11 UTC) #4
commit-bot: I haz the power
Change committed as 160619
7 years, 1 month ago (2013-10-25 20:17:28 UTC) #5
Tommy Widenflycht
7 years, 1 month ago (2013-10-28 08:34:25 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698