Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: tools/telemetry/telemetry/page/page_runner_unittest.py

Issue 449753002: Improve error reporting when indexing tab. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comments explain what to do with exceptions Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/tab_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_runner_unittest.py
diff --git a/tools/telemetry/telemetry/page/page_runner_unittest.py b/tools/telemetry/telemetry/page/page_runner_unittest.py
index 685be569d62ff59c585e5f86b520204eba758edd..8d8485115d212a28130bbc1947d6602403ecfcdb 100644
--- a/tools/telemetry/telemetry/page/page_runner_unittest.py
+++ b/tools/telemetry/telemetry/page/page_runner_unittest.py
@@ -75,6 +75,9 @@ class PageRunnerTests(unittest.TestCase):
expectations = test_expectations.TestExpectations()
page1 = page_module.Page('chrome://crash', ps)
ps.pages.append(page1)
+ page2 = page_module.Page(
+ 'file://blank.html', ps, base_dir=util.GetUnittestDataDir())
+ ps.pages.append(page2)
class Test(page_test.PageTest):
def ValidatePage(self, *args):
@@ -86,7 +89,7 @@ class PageRunnerTests(unittest.TestCase):
SetUpPageRunnerArguments(options)
results = results_options.CreateResults(EmptyMetadataForTest(), options)
page_runner.Run(Test(), ps, expectations, options, results)
- self.assertEquals(0, len(GetSuccessfulPageRuns(results)))
+ self.assertEquals(1, len(GetSuccessfulPageRuns(results)))
self.assertEquals(1, len(results.failures))
def testHandlingOfTestThatRaisesWithNonFatalUnknownExceptions(self):
« no previous file with comments | « tools/telemetry/telemetry/core/tab_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698